From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757106Ab2IMKxQ (ORCPT ); Thu, 13 Sep 2012 06:53:16 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:42406 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753138Ab2IMKxO (ORCPT ); Thu, 13 Sep 2012 06:53:14 -0400 Date: Thu, 13 Sep 2012 12:53:09 +0200 From: Wolfram Sang To: Aaro Koskinen Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, Jean Delvare Subject: Re: [PATCH 1/4] i2c: introduce i2c-cbus driver Message-ID: <20120913105309.GF14237@pengutronix.de> References: <1346703805-31598-1-git-send-email-aaro.koskinen@iki.fi> <1346703805-31598-2-git-send-email-aaro.koskinen@iki.fi> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="juZjCTNxrMaZdGZC" Content-Disposition: inline In-Reply-To: <1346703805-31598-2-git-send-email-aaro.koskinen@iki.fi> User-Agent: Mutt/1.5.20 (2009-06-14) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:221:70ff:fe71:1890 X-SA-Exim-Mail-From: w.sang@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --juZjCTNxrMaZdGZC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 03, 2012 at 11:23:22PM +0300, Aaro Koskinen wrote: > Add i2c driver to enable access to devices behind CBUS on Nokia Internet > Tablets. >=20 > The patch also adds CBUS I2C configuration for N8x0 which is one of the > users of this driver. >=20 > Cc: linux-i2c@vger.kernel.org > Acked-by: Felipe Balbi > Acked-by: Tony Lindgren > Signed-off-by: Aaro Koskinen My main question is: what is CBUS? It doesn't look like an I2C/SMBUS host controller, but some bit-banging protocol? As such, it shouldn't go to i2c/busses/. And the protocol doesn't look much like I2C, neither. There is no ACK/NACK/START/STOP, so I wonder if it should be in i2c after all... Jean, maybe you want to have a glimpse on this as well? Regards, Wolfram --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --juZjCTNxrMaZdGZC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAlBRuxUACgkQD27XaX1/VRuuYwCfYxpuY6TytsCY+hsOIPbu/Jp5 Z2kAoIE9EVeyC8gLZV38/galqUxZmMud =vXgG -----END PGP SIGNATURE----- --juZjCTNxrMaZdGZC--