linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: navin patidar <navinp@cdac.in>,
	gregkh@linuxfoundation.org, mfm@muteddisk.com,
	linux-usb@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host
Date: Fri, 14 Sep 2012 14:04:23 +0200	[thread overview]
Message-ID: <20120914120423.GD4152@breakpoint.cc> (raw)
In-Reply-To: <50531832.3050902@mvista.com>

On Fri, Sep 14, 2012 at 03:42:42PM +0400, Sergei Shtylyov wrote:
> >diff --git a/drivers/staging/usbip/stub_dev.c b/drivers/staging/usbip/stub_dev.c
> >index 92ced35..f584af8 100644
> >--- a/drivers/staging/usbip/stub_dev.c
> >+++ b/drivers/staging/usbip/stub_dev.c
> >@@ -233,6 +230,13 @@ static void stub_device_reset(struct usbip_device *ud)
> >
> >  	dev_dbg(&udev->dev, "device reset");
> >
> >+	/*reset tcp socket*/
> 
>    Add spaces after /* and before */, please.
> 
> >+	ud->tcp_socket = NULL;
> >+
> >+	/*reset kernel thread pointers */
> 
>    Here too.

I'm not sure it is required to comment the obvious things.

> WBR, Sergei

Sebastian

  reply	other threads:[~2012-09-14 12:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-14  9:53 [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host navin patidar
2012-09-14 11:42 ` Sergei Shtylyov
2012-09-14 12:04   ` Sebastian Andrzej Siewior [this message]
2012-09-14 14:29     ` navin patidar
     [not found]   ` <CAPV97yfV27x8hB2WUCVmGWEU7i21Y5K5trig2fzQBx+VB_Yk2g@mail.gmail.com>
2012-09-14 14:16     ` Sergei Shtylyov
2012-09-17 12:19 ` Greg KH
2012-09-14 13:21 navin patidar
2012-09-14 14:16 ` Dan Carpenter
2012-09-14 14:28   ` Sebastian Andrzej Siewior
2012-09-14 14:41     ` Dan Carpenter
2012-09-18  4:00 navin patidar
2012-09-18  7:40 ` Dan Carpenter
2012-09-18  9:32   ` navin patidar
2012-09-18  9:36     ` Dan Carpenter
2012-09-18 11:44       ` navin patidar
2012-09-18 13:15         ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120914120423.GD4152@breakpoint.cc \
    --to=sebastian@breakpoint.cc \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mfm@muteddisk.com \
    --cc=navinp@cdac.in \
    --cc=sshtylyov@mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).