From: Tony Lindgren <tony@atomide.com>
To: Matt Porter <mporter@ti.com>
Cc: Linux OMAP List <linux-omap@vger.kernel.org>,
Linux SPI Devel List <spi-devel-general@lists.sourceforge.net>,
Grant Likely <grant.likely@secretlab.ca>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
AnilKumar <anilkumar@ti.com>
Subject: Re: [PATCH v2 2/2] ARM: OMAP2+: Enable pinctrl dummy states
Date: Mon, 17 Sep 2012 10:28:49 -0700 [thread overview]
Message-ID: <20120917172849.GQ4521@atomide.com> (raw)
In-Reply-To: <1347902538-21208-3-git-send-email-mporter@ti.com>
* Matt Porter <mporter@ti.com> [120917 10:21]:
> Enable pinctrl dummy states for all OMAP platforms that don't
> populate DT. This allows drivers to be converted to pinctrl
> and not generate new warnings on platforms that do not provide
> pinctrl data. These platforms already have pinmuxes configured
> before the drivers probe.
Thanks this should do the trick until we've converted to use DT.
I'll queue this for the upcoming merge window.
Regards,
Tony
> Signed-off-by: Matt Porter <mporter@ti.com>
> ---
> arch/arm/mach-omap2/devices.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
> index 1efa984..6ef4010 100644
> --- a/arch/arm/mach-omap2/devices.c
> +++ b/arch/arm/mach-omap2/devices.c
> @@ -17,6 +17,7 @@
> #include <linux/err.h>
> #include <linux/slab.h>
> #include <linux/of.h>
> +#include <linux/pinctrl/machine.h>
> #include <linux/platform_data/omap4-keypad.h>
>
> #include <asm/mach-types.h>
> @@ -628,6 +629,10 @@ static inline void omap_init_vout(void) {}
>
> static int __init omap2_init_devices(void)
> {
> + /* Enable dummy states for those platforms without pinctrl support */
> + if (!of_have_populated_dt())
> + pinctrl_provide_dummies();
> +
> /*
> * please keep these calls, and their implementations above,
> * in alphabetical order so they're easier to sort through.
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2012-09-17 17:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 17:22 [PATCH v2 0/2] Add pinctrl support to omap2-mcspi Matt Porter
2012-09-17 17:22 ` [PATCH v2 1/2] spi: omap2-mcspi: add pinctrl support Matt Porter
2012-09-17 17:26 ` Tony Lindgren
2012-09-18 5:27 ` Shubhrajyoti
2012-09-18 12:03 ` Matt Porter
2012-09-17 17:22 ` [PATCH v2 2/2] ARM: OMAP2+: Enable pinctrl dummy states Matt Porter
2012-09-17 17:28 ` Tony Lindgren [this message]
2012-09-18 12:11 ` Linus Walleij
2012-09-17 17:27 ` [PATCH v2 0/2] Add pinctrl support to omap2-mcspi Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120917172849.GQ4521@atomide.com \
--to=tony@atomide.com \
--cc=anilkumar@ti.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mporter@ti.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).