From: Arnd Bergmann <arnd@arndb.de>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
Fengguang Wu <fengguang.wu@intel.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Paul Walmsley <paul@pwsan.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Olof Johansson <olof@lixom.net>, Felipe Balbi <balbi@ti.com>
Subject: Re: [PATCH] mfd: Fix compile for twl-core.c by removing cpu_is_omap usage
Date: Mon, 17 Sep 2012 20:43:45 +0000 [thread overview]
Message-ID: <201209172043.45461.arnd@arndb.de> (raw)
In-Reply-To: <20120917202943.GV4521@atomide.com>
On Monday 17 September 2012, Tony Lindgren wrote:
> Commit 7d7e1eba (ARM: OMAP2+: Prepare for irqs.h removal) broke
> compile for non-omap as include plat/cpu.h was added:
>
> drivers/mfd/twl-core.c:49:22: fatal error: plat/cpu.h: No such file or directory
>
> This header was indirectly included earlier when SPARSE_IRQ was not
> set, but does not exist on most platforms.
>
> Fix the problem by removing the cpu_is_omap usage that should
> not exist in drivers at all. We can do this by adding proper
> clock aliases for the twl-core.c drivers, and drop separate
> handling for cases when clock framework is not available as
> the behaviour will stay the same.
>
> Note that we need to add a platform device to avoid using the
> i2c provided names that may be different on various omaps.
>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Paul Walmsley <paul@pwsan.com>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Olof Johansson <olof@lixom.net>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2012-09-17 20:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 20:29 [PATCH] mfd: Fix compile for twl-core.c by removing cpu_is_omap usage Tony Lindgren
2012-09-17 20:43 ` Arnd Bergmann [this message]
2012-09-17 22:08 ` Paul Walmsley
2012-09-17 22:14 ` Tony Lindgren
2012-09-17 22:24 ` Paul Walmsley
2012-09-17 22:26 ` Tony Lindgren
2012-09-18 2:30 ` Tony Lindgren
2012-09-17 22:59 ` Samuel Ortiz
2012-09-18 4:51 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209172043.45461.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=fengguang.wu@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=olof@lixom.net \
--cc=paul@pwsan.com \
--cc=sameo@linux.intel.com \
--cc=sfr@canb.auug.org.au \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).