From: Andrew Morton <akpm@linux-foundation.org>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: Ingo Molnar <mingo@kernel.org>,
x86@kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com
Subject: Re: section mismatch for acpi_unmap_lsapic()
Date: Tue, 18 Sep 2012 12:50:38 -0700 [thread overview]
Message-ID: <20120918125038.110b8716.akpm@linux-foundation.org> (raw)
In-Reply-To: <5057D123.7040109@cn.fujitsu.com>
On Tue, 18 Sep 2012 09:40:51 +0800
Wen Congyang <wency@cn.fujitsu.com> wrote:
> At 09/17/2012 07:07 PM, Ingo Molnar Wrote:
> >
> > * Jerry Snitselaar <dev@snitselaar.org> wrote:
> >
> >> Commit 13ad20c1 "x86 cpu_hotplug: unmap cpu2node when the cpu is
> >> hotremoved" in linux-next added code to acpi_unmap_lsapic() that
> >> causes section mismatch warnings:
> >>
> >> WARNING: vmlinux.o(.text+0x694f2): Section mismatch in reference from the function acpi_unmap_lsapic()
> >> to the function .cpuinit.text:numa_clear_node()
> >> WARNING: vmlinux.o(.text+0x694eb): Section mismatch in reference from the function acpi_unmap_lsapic()
> >> to the variable .cpuinit.data:__apicid_to_node
> >>
> >>
> >> Does acpi_unmap_lsapic() need a wrapper like the one that was made for
> >> acpi_map_lsapic() or can it just be annotated __ref ? I guess my
> >> question is would be there be a reason that the wrapper was created
> >> for acpi_map_lsapic() instead of just annotating __ref besides
> >> allowing the code for _apic_map_lsapic() to be dropped when
> >> HOTPLUG_CPU wasn't configured?
> >
> > That commit comes from -mm AFAICS. Involved parties Cc:-ed.
>
> Sorry for introducing this warning. numa_clear_node() is in cpuinit
> section, and it will be called in acpi_unmap_lsapic(), so I agree
> to add __ref to this function. Should I need to post another patch
> to fix it or just update the patch?
Either a new patch or a fixup is OK for me (I'll turn a new patch into
a fixup so I and others can see what changed).
People who run git trees prefer fixup patches due to extensive lameness.
I did this:
--- a/arch/x86/kernel/acpi/boot.c~cpu_hotplug-unmap-cpu2node-when-the-cpu-is-hotremoved-fix
+++ a/arch/x86/kernel/acpi/boot.c
@@ -689,7 +689,7 @@ int __ref acpi_map_lsapic(acpi_handle ha
}
EXPORT_SYMBOL(acpi_map_lsapic);
-int acpi_unmap_lsapic(int cpu)
+int __ref acpi_unmap_lsapic(int cpu)
{
#ifdef CONFIG_ACPI_NUMA
set_apicid_to_node(per_cpu(x86_cpu_to_apicid, cpu), NUMA_NO_NODE);
_
prev parent reply other threads:[~2012-09-18 19:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 16:38 section mismatch for acpi_unmap_lsapic() Jerry Snitselaar
2012-09-17 11:07 ` Ingo Molnar
2012-09-18 1:40 ` Wen Congyang
2012-09-18 19:50 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120918125038.110b8716.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=wency@cn.fujitsu.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).