linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: "Sjur Brændeland" <sjurbren@gmail.com>,
	"Amit Shah" <amit.shah@redhat.com>,
	linux-kernel@vger.kernel.org, "Ohad Ben-Cohen" <ohad@wizery.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH repost] virtio: don't crash when device is buggy
Date: Wed, 19 Sep 2012 01:24:05 +0300	[thread overview]
Message-ID: <20120918222405.GB20285@redhat.com> (raw)
In-Reply-To: <87ehm1s28q.fsf@rustcorp.com.au>

On Mon, Sep 17, 2012 at 01:57:17PM +0930, Rusty Russell wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
> 
> > Because of a sanity check in virtio_dev_remove, a buggy device can crash
> > kernel.  And in case of rproc it's userspace so it's not a good idea.
> > We are unloading a driver so how bad can it be?
> > Be less aggressive in handling this error: if it's a driver bug,
> > warning once should be enough.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >
> > --
> >
> > 3.6 material?
> 
> I have already applied, this, but it's not for stable, since it's a
> "theoretical bugfix".  That check has been in there forever and noone
> AFAIK has actually struck it.
> 
> Cheers,
> Rusty.

Yes but can't malicious userspace trigger this with remoteproc? If yes
it's not a question of whether anyone has struck it since people don't
normally run malicious userspace :)

-- 
MST

  reply	other threads:[~2012-09-18 22:22 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-03 13:51 [RFC 1/2] virtio_console: Add support for DMA memory allocation sjur.brandeland
2012-09-03 13:51 ` [RFC 2/2] virtio_console: Add feature to disable console port sjur.brandeland
2012-09-03 14:30 ` [RFC 1/2] virtio_console: Add support for DMA memory allocation Michael S. Tsirkin
2012-09-03 14:57   ` Sjur Brændeland
2012-09-03 20:27     ` Michael S. Tsirkin
2012-09-04  6:07       ` Rusty Russell
2012-09-05 13:00         ` Sjur Brændeland
2012-09-05 14:35           ` Michael S. Tsirkin
2012-09-05 18:15             ` Sjur Brændeland
2012-09-05 19:16               ` Michael S. Tsirkin
2012-09-07  9:24                 ` Sjur Brændeland
2012-09-04 11:28       ` Sjur Brændeland
2012-09-04 13:50         ` Michael S. Tsirkin
2012-09-04 16:58           ` Sjur Brændeland
2012-09-04 18:55             ` Michael S. Tsirkin
2012-09-06  2:04               ` Rusty Russell
2012-09-06  5:27                 ` Michael S. Tsirkin
2012-09-10 22:11                   ` Michael S. Tsirkin
2012-09-12  6:24                     ` Rusty Russell
2012-09-07  8:35                 ` Sjur Brændeland
2012-09-16  9:44                 ` [PATCH repost] virtio: don't crash when device is buggy Michael S. Tsirkin
2012-09-17  4:27                   ` Rusty Russell
2012-09-18 22:24                     ` Michael S. Tsirkin [this message]
2012-09-19  4:10                       ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120918222405.GB20285@redhat.com \
    --to=mst@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ohad@wizery.com \
    --cc=rusty@rustcorp.com.au \
    --cc=sjurbren@gmail.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).