Hi again, On Wed, Sep 19, 2012 at 08:24:44PM +0300, Felipe Balbi wrote: > > > at minimum this should've come with a proper revision check anyway. > > > > > > > Actually most of it is under a rev check :) > > fair enough. one extra comment here. That revision check is not related to the silicon errata you mention. That revision check is there because the bit definition of that particular register has changed a little bit, so we're just handling a slightly different programming model between older and newer revisions. -- balbi