linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <w.sang@pengutronix.de>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Jean Delvare <khali@linux-fr.org>,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-i2c@vger.kernel.org
Subject: Re: [PATCH 1/4] i2c: introduce i2c-cbus driver
Date: Thu, 20 Sep 2012 12:43:05 +0200	[thread overview]
Message-ID: <20120920104305.GA2609@pengutronix.de> (raw)
In-Reply-To: <20120919200812.GA2063@blackmetal.musicnaut.iki.fi>

[-- Attachment #1: Type: text/plain, Size: 1480 bytes --]

On Wed, Sep 19, 2012 at 11:08:13PM +0300, Aaro Koskinen wrote:
> On Fri, Sep 14, 2012 at 12:08:06PM +0200, Wolfram Sang wrote:
> > On Mon, Sep 03, 2012 at 11:23:22PM +0300, Aaro Koskinen wrote:
> > > Add i2c driver to enable access to devices behind CBUS on Nokia Internet
> > > Tablets.
> > > 
> > > The patch also adds CBUS I2C configuration for N8x0 which is one of the
> > > users of this driver.
> > > 
> > > Cc: linux-i2c@vger.kernel.org
> > > Acked-by: Felipe Balbi <balbi@ti.com>
> > > Acked-by: Tony Lindgren <tony@atomide.com>
> > > Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> > 
> > OK, I found the short paragrahp about CBUS in the I2C spec, so I2C might
> > be an appropriate place. Still, before deciding if it should rather be
> > in the core directory, I still have a few questions.
> 
> Thanks for your feedback. I will fix up the incorrect comments, and do
> other improvements (e.g. use devm_* stuff) in the next version.
> 
> The questions about delays and bit counts are very valid, but it's
> difficult to do anything with them due to lack of documentation and HW on
> which to test - I have Nokia tablets to test the driver, and the driver
> is very reliable, but I do not know of any other HW with CBUS. :-/

Fine enough, then please add comments saying that.

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2012-09-20 10:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-03 20:23 [PATCH 0/4] cbus/retu drivers to mainline Aaro Koskinen
2012-09-03 20:23 ` [PATCH 1/4] i2c: introduce i2c-cbus driver Aaro Koskinen
2012-09-04  9:05   ` Felipe Balbi
2012-09-04  9:31     ` Aaro Koskinen
2012-09-04 11:41       ` Felipe Balbi
2012-09-13 10:53   ` Wolfram Sang
2012-09-13 14:51     ` Aaro Koskinen
2012-09-14 10:08   ` Wolfram Sang
2012-09-14 10:21     ` Jean Delvare
2012-09-14 12:16     ` Felipe Balbi
2012-09-19 20:08     ` Aaro Koskinen
2012-09-20 10:43       ` Wolfram Sang [this message]
2012-09-03 20:23 ` [PATCH 2/4] mfd: introduce retu-mfd driver Aaro Koskinen
2012-09-19 16:02   ` Samuel Ortiz
2012-09-19 20:09     ` Aaro Koskinen
2012-09-03 20:23 ` [PATCH 3/4] watchdog: introduce retu_wdt driver Aaro Koskinen
2012-09-03 20:23 ` [PATCH 4/4] input: misc: introduce retu-pwrbutton Aaro Koskinen
2012-09-04 16:09 ` [PATCH 0/4] cbus/retu drivers to mainline Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120920104305.GA2609@pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=aaro.koskinen@iki.fi \
    --cc=khali@linux-fr.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).