On Mon, Sep 17, 2012 at 07:01:16AM +0200, Arun MURTHY wrote: > > On Fri, Sep 07, 2012 at 03:22:09PM +0200, Thierry Reding wrote: > > > On Mon, Sep 03, 2012 at 01:28:44PM +0200, Arun MURTHY wrote: > > > > > On Sun, Sep 2, 2012 at 12:30 PM, Thierry Reding > > > > > wrote: > > > > > > > > > > > This commit moves the driver to drivers/pwm and converts it to > > > > > > the new PWM framework. > > > > > > > > > > > > Signed-off-by: Thierry Reding > > > > > > --- > > > > > > Note: I'll take this through the PWM tree, but I'd like to have > > > > > > it acknowledged by a few people who know the hardware and can > > > > > > actually test whether this still works. > > > > > > > > > > Pls include Arun on these patches, he'll know best if it'll work or not. > > > > > > > > > > I have one generic question: will this alter the layout of sysfs > > > > > so we need to change userspace? I had such issues before when > > > > > moving drivers to new busses... > > > > > > > > > > > > > Since this pwm framework is still a set of exported functions in a > > > > header file, the file architecture doesn't really matter. > > > > Using this driver, either leds-pwm and backlight-pwm is used to > > > > register and this is where actual registration happens(sysfs entry is > > created). > > > > > > Hi Arun, > > > > > > Have you been able to verify, then, that the driver still works after > > > this patch? Can I add your Acked-by as well? > > > > Hi Arun, > > > > any news on this? > > > > Thierry > > Hi Thierry, > Works with certain changes in platform data which I can manage > to push it later. > > Acked-by: Arun Murthy Thanks. I've pushed this patch to my for-next branch. Thierry