From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755221Ab2ITMtJ (ORCPT ); Thu, 20 Sep 2012 08:49:09 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:49044 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754666Ab2ITMtG (ORCPT ); Thu, 20 Sep 2012 08:49:06 -0400 Date: Thu, 20 Sep 2012 08:49:04 -0400 From: Mark Brown To: Ola Lilja Cc: Lee Jones , "linus.walleij@linaro.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "alsa-devel@alsa-project.org" , Linus WALLEIJ , "arnd@arndb.de" , STEricsson_nomadik_linux Subject: Re: [RESENDING] [PATCH 07/22] ASoC: Ux500: Initialise PCM from MSP probe rather than as a device Message-ID: <20120920124903.GO17666@opensource.wolfsonmicro.com> References: <1344527268-5964-1-git-send-email-lee.jones@linaro.org> <1344527268-5964-8-git-send-email-lee.jones@linaro.org> <20120919133343.GH25694@gmail.com> <505ADBE6.6080509@stericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <505ADBE6.6080509@stericsson.com> X-Cookie: Blow it out your ear. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 20, 2012 at 11:03:34AM +0200, Ola Lilja wrote: > I still don't like this. It is the dai_link-struct that bothers me. We have > "ux500-msp-i2s.1" as name of the platform AND the cpu_dai. The MSP I2S-block is > not the platform and it is certainly not both platform and cpu-DAI at the same time. > Mark: Did you have a solution for this? Couldn't we just put NULL on the > platform_name instead? No, having no platform driver means a direct device<->device link (like baseband<->CODEC). You could always register the platform with a -dma added in the name or something, it'd be a bit more code but it'd work, but the framework doesn't particularly care what you call these things.