From: David Miller <davem@davemloft.net>
To: jjolly@suse.com
Cc: linux-kernel@vger.kernel.org, venkat.x.venkatsubra@oracle.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] rds: Error on offset mismatch if not loopback
Date: Sat, 22 Sep 2012 15:25:24 -0400 (EDT) [thread overview]
Message-ID: <20120922.152524.1294103117346567757.davem@davemloft.net> (raw)
In-Reply-To: <20120921213239.GJ14393@linux-tkdk.sfcn.org>
From: John Jolly <jjolly@suse.com>
Date: Fri, 21 Sep 2012 15:32:40 -0600
> Attempting an rds connection from the IP address of an IPoIB interface
> to itself causes a kernel panic due to a BUG_ON() being triggered.
> Making the test less strict allows rds-ping to work without crashing
> the machine.
>
> A local unprivileged user could use this flaw to crash the system.
>
> Signed-off-by: John Jolly <jjolly@suse.com>
Besides the questions being asked of you by Venkat Venkatsubra, this
patch has another issue.
It has been completely corrupted by your email client, it has
turned all TAB characters into spaces, making the patch useless.
Please learn how to send a patch unmolested in the body of your
email. Test it by emailing the patch to yourself, and verifying
that you can in fact apply the patch you receive in that email.
Then, and only then, should you consider making a new submission
of this patch.
Use Documentation/email-clients.txt for guidance.
next prev parent reply other threads:[~2012-09-22 19:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 21:32 [PATCH] rds: Error on offset mismatch if not loopback John Jolly
2012-09-21 21:38 ` Venkat Venkatsubra
2012-09-22 19:25 ` David Miller [this message]
[not found] ` <CAKA=qzac9=UhLF_Z4FnnH+sR7xvkDux4oayC6dPYe=hMLsDxRg@mail.gmail.com>
2013-11-13 4:24 ` Josh Hunt
2013-11-13 15:16 ` Venkat Venkatsubra
2013-11-13 17:40 ` Josh Hunt
2013-11-14 0:55 ` Honggang LI
2013-11-14 1:27 ` Josh Hunt
2013-11-14 13:43 ` Venkat Venkatsubra
2013-11-15 2:32 ` Honggang LI
2013-11-19 23:33 ` Venkat Venkatsubra
2013-11-20 18:09 ` Venkat Venkatsubra
2013-11-20 18:54 ` David Miller
2013-11-20 21:28 ` Venkat Venkatsubra
2013-11-13 6:09 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2012-09-20 7:11 John Jolly
2012-09-21 17:20 ` David Miller
2012-09-21 21:28 ` John Jolly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120922.152524.1294103117346567757.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jjolly@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=venkat.x.venkatsubra@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).