From: Fengguang Wu <fengguang.wu@intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Shaun Ruffell <sruffell@digium.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Shaohui Xie <Shaohui.Xie@freescale.com>,
Kim Phillips <kim.phillips@freescale.com>,
linux-edac@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@redhat.com>
Subject: Re: Linux 3.6-rc6
Date: Sun, 23 Sep 2012 08:15:22 +0800 [thread overview]
Message-ID: <20120923001522.GA8383@localhost> (raw)
In-Reply-To: <CA+55aFzCzF5DZvR6i=Jg+0abSzN_nbAVr7Ef1dzmR3_NNLWmfw@mail.gmail.com>
On Sat, Sep 22, 2012 at 11:57:23AM -0700, Linus Torvalds wrote:
> On Fri, Sep 21, 2012 at 5:59 PM, Shaun Ruffell <sruffell@digium.com> wrote:
> >
> > I posted patches [1,2,3] that resolve the issue for me. Shaohui Xie
> > also hit the issue and posted a slightly different patch [4]. The
> > patches are currently waiting for Mauro, who I understand is
> > catching up since returning from San Diego, to check them out.
> >
> > [1] http://marc.info/?l=linux-kernel&m=134764595921752&w=2
> > [2] http://marc.info/?l=linux-kernel&m=134764594721747&w=2
> > [3] http://marc.info/?l=linux-kernel&m=134764597921761&w=2
> > [4] http://marc.info/?l=linux-kernel&m=134753579818528&w=2
>
> That first patch needs a sign-off from you, since you are passing on
> somebody elses patch.
>
> Looking at that patch, the patch seems to be a memory leak (?) leaking
> the "channels" allocation, along with fixing an odd and incorrect
Yes.
> kfree (and access) of mci->csrows[i]. If that is correct, please write
Right.
> a proper changelog. The current changelog for that thing is totally
> pointless, and doesn't actually explain what the patch *does*.
Sorry I'll send the fix with more complete changelog in a standalone
patch for review.
> I'd also like some ack's from people, and I'd love to know which
> commit introduced the problem(s). If this problem is new to 3.6, I
> want to know what caused it, and if it is *not* new, then the thing
> needs to be marked for stable. Please?
It's a new bug to 3.6.
Thanks,
Fengguang
next prev parent reply other threads:[~2012-09-23 0:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-16 22:59 Linux 3.6-rc6 Linus Torvalds
2012-09-22 0:59 ` Shaun Ruffell
2012-09-22 18:57 ` Linus Torvalds
2012-09-23 0:15 ` Fengguang Wu [this message]
2012-09-23 1:26 ` [PATCH] edac_mc: edac_mc_free() cannot assume mem_ctl_info is registered in sysfs Shaun Ruffell
2012-09-23 0:18 ` [PATCH] edac_mc: fix messy kfree calls in the error path Fengguang Wu
2012-09-23 13:32 ` Linux 3.6-rc6 Mauro Carvalho Chehab
2012-09-23 22:52 Notifications
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120923001522.GA8383@localhost \
--to=fengguang.wu@intel.com \
--cc=Shaohui.Xie@freescale.com \
--cc=kim.phillips@freescale.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=sruffell@digium.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).