From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Feng Tang <feng.tang@intel.com>
Cc: mingo@elte.hu, a.p.zijlstra@chello.nl, andi@firstfloor.org,
namhyung@kernel.org, dsahern@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 7/9] perf header: Add check_perf_magic() func
Date: Mon, 24 Sep 2012 13:01:51 -0300 [thread overview]
Message-ID: <20120924160151.GC9977@infradead.org> (raw)
In-Reply-To: <1348500251-9937-8-git-send-email-feng.tang@intel.com>
Em Mon, Sep 24, 2012 at 11:24:09PM +0800, Feng Tang escreveu:
> With this func, other modules can basically check whether a file
> is a legal perf data file by checking its first 8 bytes aginst
> all possible perf magic nunbers.
Please consider submitting a patch to http://www.darwinsys.com/file/ :-)
- Arnaldo
> Signed-off-by: Feng Tang <feng.tang@intel.com>
> ---
> tools/perf/util/header.c | 11 +++++++++++
> tools/perf/util/header.h | 1 +
> 2 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
> index ad72b28..555cb68 100644
> --- a/tools/perf/util/header.c
> +++ b/tools/perf/util/header.c
> @@ -2174,6 +2174,17 @@ static int try_all_pipe_abis(uint64_t hdr_sz, struct perf_header *ph)
> return -1;
> }
>
> +/* Return 0 if matched */
> +int check_perf_magic(u64 magic)
> +{
> + if (!memcmp(&magic, __perf_magic1, sizeof(magic))
> + || magic == __perf_magic2
> + || magic == __perf_magic2_sw)
> + return 0;
> +
> + return -1;
> +}
> +
> static int check_magic_endian(u64 magic, uint64_t hdr_sz,
> bool is_pipe, struct perf_header *ph)
> {
> diff --git a/tools/perf/util/header.h b/tools/perf/util/header.h
> index 58de08b..af1a51c 100644
> --- a/tools/perf/util/header.h
> +++ b/tools/perf/util/header.h
> @@ -131,6 +131,7 @@ int perf_event__synthesize_build_id(struct perf_tool *tool,
> int perf_event__process_build_id(struct perf_tool *tool,
> union perf_event *event,
> struct perf_session *session);
> +int check_perf_magic(u64 magic);
>
> /*
> * arch specific callback
> --
> 1.7.1
next prev parent reply other threads:[~2012-09-24 16:02 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 15:24 [PATCH v3 0/9] perf tools: Add script browser and runtime data file switch Feng Tang
2012-09-24 15:24 ` [PATCH v3 1/9] perf hists: Move hists_init() from util/evsel.c to util/hist.c Feng Tang
2012-09-24 16:02 ` Arnaldo Carvalho de Melo
2012-09-25 1:25 ` Namhyung Kim
2012-09-25 11:05 ` Arnaldo Carvalho de Melo
2012-09-25 12:59 ` Namhyung Kim
2012-09-25 13:30 ` perf tools regression testing was " Arnaldo Carvalho de Melo
2012-09-25 13:47 ` Namhyung Kim
2012-09-25 14:10 ` Arnaldo Carvalho de Melo
2012-09-25 8:03 ` Feng Tang
2012-09-24 15:24 ` [PATCH v3 2/9] perf tool: Add a global variable "const char *input_name" Feng Tang
2012-09-24 15:24 ` [PATCH v3 3/9] perf script: Add more filter to find_scripts() Feng Tang
2012-09-25 1:47 ` Namhyung Kim
2012-09-26 8:56 ` Feng Tang
2012-09-27 4:45 ` Namhyung Kim
2012-09-27 10:39 ` Namhyung Kim
2012-09-24 15:24 ` [PATCH v3 4/9] perf ui/browser: Add a browser for perf script Feng Tang
2012-09-24 15:24 ` [PATCH v3 5/9] perf ui/browser: Integrate script browser into annotation browser Feng Tang
2012-09-24 15:24 ` [PATCH v3 6/9] perf ui/browser: Integrate script browser into main hists browser Feng Tang
2012-09-24 15:24 ` [PATCH v3 7/9] perf header: Add check_perf_magic() func Feng Tang
2012-09-24 16:01 ` Arnaldo Carvalho de Melo [this message]
2012-09-25 2:07 ` Namhyung Kim
2012-09-25 8:21 ` Feng Tang
2012-09-25 11:22 ` Arnaldo Carvalho de Melo
2012-09-24 15:24 ` [PATCH v3 8/9] perf hists browser: Add option for runtime switching perf data file Feng Tang
2012-09-25 2:11 ` Namhyung Kim
2012-09-25 8:20 ` Feng Tang
2012-09-25 11:17 ` Arnaldo Carvalho de Melo
2012-09-26 7:57 ` Feng Tang
2012-09-27 4:02 ` Namhyung Kim
2012-09-27 5:43 ` Feng Tang
2012-09-24 15:24 ` [PATCH v3 9/9] perf report: Enable the runtime switching of " Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120924160151.GC9977@infradead.org \
--to=acme@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=feng.tang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).