* [PATCH/RFC/cosmetic] driver base: use available pointer
@ 2012-09-24 9:48 Guennadi Liakhovetski
2012-09-26 21:09 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Guennadi Liakhovetski @ 2012-09-24 9:48 UTC (permalink / raw)
To: linux-kernel; +Cc: Greg Kroah-Hartman
Don't recalculate an available pointer.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
---
diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index a1a7225..efe9aa9 100644
--- a/drivers/base/platform.c
+++ b/drivers/base/platform.c
@@ -166,8 +166,8 @@ static void platform_device_release(struct device *dev)
struct platform_object *pa = container_of(dev, struct platform_object,
pdev.dev);
- of_device_node_put(&pa->pdev.dev);
- kfree(pa->pdev.dev.platform_data);
+ of_device_node_put(dev);
+ kfree(dev->platform_data);
kfree(pa->pdev.mfd_cell);
kfree(pa->pdev.resource);
kfree(pa);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH/RFC/cosmetic] driver base: use available pointer
2012-09-24 9:48 [PATCH/RFC/cosmetic] driver base: use available pointer Guennadi Liakhovetski
@ 2012-09-26 21:09 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2012-09-26 21:09 UTC (permalink / raw)
To: Guennadi Liakhovetski; +Cc: linux-kernel
On Mon, Sep 24, 2012 at 11:48:28AM +0200, Guennadi Liakhovetski wrote:
> Don't recalculate an available pointer.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
> diff --git a/drivers/base/platform.c b/drivers/base/platform.c
> index a1a7225..efe9aa9 100644
> --- a/drivers/base/platform.c
> +++ b/drivers/base/platform.c
> @@ -166,8 +166,8 @@ static void platform_device_release(struct device *dev)
> struct platform_object *pa = container_of(dev, struct platform_object,
> pdev.dev);
>
> - of_device_node_put(&pa->pdev.dev);
> - kfree(pa->pdev.dev.platform_data);
> + of_device_node_put(dev);
> + kfree(dev->platform_data);
If you don't mind, I'll leave it as-is, as it makes it a bit more
obvious as to exactly what we are cleaning up here.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-26 21:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-24 9:48 [PATCH/RFC/cosmetic] driver base: use available pointer Guennadi Liakhovetski
2012-09-26 21:09 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).