On Thu, Sep 27, 2012 at 10:31:55AM +0300, Andy Shevchenko wrote: > From: Heikki Krogerus > commit log would be great. > Signed-off-by: Heikki Krogerus > Signed-off-by: Andy Shevchenko > --- > drivers/dma/dw_dmac.c | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) > > diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c > index c4b0eb3..0b88ced 100644 > --- a/drivers/dma/dw_dmac.c > +++ b/drivers/dma/dw_dmac.c > @@ -1700,6 +1700,7 @@ MODULE_DEVICE_TABLE(of, dw_dma_id_table); > #endif > > static struct platform_driver dw_driver = { > + .probe = dw_probe, probe's in __init section. This is wrong. You need to change probe __devinit. > .remove = __devexit_p(dw_remove), > .shutdown = dw_shutdown, > .driver = { > @@ -1709,17 +1710,7 @@ static struct platform_driver dw_driver = { > }, > }; > > -static int __init dw_init(void) > -{ > - return platform_driver_probe(&dw_driver, dw_probe); > -} > -subsys_initcall(dw_init); > - > -static void __exit dw_exit(void) > -{ > - platform_driver_unregister(&dw_driver); > -} > -module_exit(dw_exit); > +module_platform_driver(dw_driver); > > MODULE_LICENSE("GPL v2"); > MODULE_DESCRIPTION("Synopsys DesignWare DMA Controller driver"); > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- balbi