From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759264Ab2I2A0g (ORCPT ); Fri, 28 Sep 2012 20:26:36 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:57724 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759086Ab2I2A0e (ORCPT ); Fri, 28 Sep 2012 20:26:34 -0400 X-Originating-IP: 217.70.178.130 X-Originating-IP: 50.43.46.74 Date: Fri, 28 Sep 2012 17:26:26 -0700 From: Josh Triplett To: Daniel Santos Cc: LKML , Andi Kleen , Andrea Arcangeli , Andrew Morton , Christopher Li , David Daney , David Howells , Joe Perches , Konstantin Khlebnikov , linux-sparse@vger.kernel.org, Michel Lespinasse , Paul Gortmaker , Pavel Pisa , Peter Zijlstra , Steven Rostedt Subject: Re: [PATCH 7/10] compiler{,-gcc4}.h: Introduce __flatten function attribute Message-ID: <20120929002626.GD13907@jtriplet-mobl1> References: <1348874411-28288-1-git-send-email-daniel.santos@pobox.com> <1348874411-28288-8-git-send-email-daniel.santos@pobox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1348874411-28288-8-git-send-email-daniel.santos@pobox.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 28, 2012 at 06:20:08PM -0500, Daniel Santos wrote: > --- a/include/linux/compiler-gcc4.h > +++ b/include/linux/compiler-gcc4.h > @@ -15,7 +15,12 @@ > > #if GCC_VERSION >= 40102 > # define __compiletime_object_size(obj) __builtin_object_size(obj, 0) > -#endif > + > +/* flatten introduced in 4.1, but broken in 4.6.0 (gcc bug #48731)*/ > +# if GCC_VERSION != 40600 > +# define __flatten __attribute__((flatten)) > +# endif > +#endif /* GCC_VERSION >= 40102 */ Same comment as before: why 40102 rather than 40100? - Josh Triplett