linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Minchan Kim <minchan@kernel.org>,
	Thierry Reding <thierry.reding@avionic-design.de>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Michal Nazarewicz <mina86@mina86.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Peter Ujfalusi <peter.ujfalusi@ti.com>
Subject: [PATCH] mm: compaction: Iron out isolate_freepages_block() and isolate_freepages_range() -fix1
Date: Thu, 4 Oct 2012 15:00:17 +0100	[thread overview]
Message-ID: <20121004140017.GW29125@suse.de> (raw)
In-Reply-To: <20120928054330.GA27594@bbox>

The following patch is still missing from linux-next/akpm so am
resending in case it got lost in the mess.


CMA is reported to be broken in next-20120926. Minchan Kim pointed out
that this was due to nr_scanned != total_isolated in the case of CMA
because PageBuddy pages are one scan but many isolations in CMA. This
patch should address the problem.

This patch is a fix for
mm-compaction-acquire-the-zone-lock-as-late-as-possible-fix-2.patch

Signed-off-by: Mel Gorman <mgorman@suse.de>

diff --git a/mm/compaction.c b/mm/compaction.c
index 136debd..ed3b8f1 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -282,6 +282,7 @@ static unsigned long isolate_freepages_block(struct compact_control *cc,
 {
 	int nr_scanned = 0, total_isolated = 0;
 	struct page *cursor, *valid_page = NULL;
+	unsigned long nr_strict_required = end_pfn - blockpfn;
 	unsigned long flags;
 	bool locked = false;
 
@@ -342,10 +343,10 @@ static unsigned long isolate_freepages_block(struct compact_control *cc,
 
 	/*
 	 * If strict isolation is requested by CMA then check that all the
-	 * pages scanned were isolated. If there were any failures, 0 is
+	 * pages requested were isolated. If there were any failures, 0 is
 	 * returned and CMA will fail.
 	 */
-	if (strict && nr_scanned != total_isolated)
+	if (strict && nr_strict_required != total_isolated)
 		total_isolated = 0;
 
 	if (locked)

  parent reply	other threads:[~2012-10-04 14:00 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-27 11:29 CMA broken in next-20120926 Thierry Reding
2012-09-27 15:59 ` Marek Szyprowski
2012-09-27 17:49   ` Mark Brown
2012-09-27 22:11 ` Andrew Morton
2012-09-28  5:43   ` Minchan Kim
2012-09-28  6:10     ` Thierry Reding
2012-09-28  7:44     ` Peter Ujfalusi
2012-09-28  7:56     ` Mel Gorman
2012-09-28  8:09       ` Mel Gorman
2012-09-28  8:37     ` Mel Gorman
2012-09-28  8:48       ` Peter Ujfalusi
2012-09-28 10:27         ` Mel Gorman
2012-09-28 10:32           ` Thierry Reding
2012-09-28 10:38             ` Thierry Reding
2012-09-28 10:51               ` Thierry Reding
2012-09-28 11:07                 ` Mel Gorman
2012-09-28 11:39                   ` Thierry Reding
2012-09-28 12:43                     ` Mel Gorman
2012-10-01 14:24                       ` Thierry Reding
2012-10-02 12:48                         ` Thierry Reding
2012-10-02 14:41                           ` Mel Gorman
2012-10-02 15:03                             ` Thierry Reding
2012-10-02 15:12                               ` Mel Gorman
2012-10-08  8:06                                 ` Minchan Kim
2012-10-08  8:48                                   ` Mel Gorman
2012-10-09  8:40                                     ` Bartlomiej Zolnierkiewicz
2012-10-09 10:11                                       ` Mel Gorman
2012-10-09 11:02                                         ` Thierry Reding
2012-10-09 11:08                                         ` Bartlomiej Zolnierkiewicz
2012-10-09 11:32                                           ` Mel Gorman
2012-10-09 11:38                                           ` Thierry Reding
2012-09-28 10:52               ` Mel Gorman
2012-10-04 14:00     ` Mel Gorman [this message]
2012-10-05  9:59       ` [PATCH] mm: compaction: Iron out isolate_freepages_block() and isolate_freepages_range() -fix2 Mel Gorman
2012-10-08  6:50         ` Minchan Kim
2012-10-08  6:53       ` [PATCH] mm: compaction: Iron out isolate_freepages_block() and isolate_freepages_range() -fix1 Minchan Kim
2012-10-04 14:03     ` [PATCH] mm: compaction: Cache if a pageblock was scanned and no pages were isolated -fix3 Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121004140017.GW29125@suse.de \
    --to=mgorman@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mina86@mina86.com \
    --cc=minchan@kernel.org \
    --cc=peter.ujfalusi@ti.com \
    --cc=thierry.reding@avionic-design.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).