From: Greg KH <firstname.lastname@example.org>
To: Andrew Morton <email@example.com>
Cc: Geert Uytterhoeven <firstname.lastname@example.org>,
Ralf Baechle <email@example.com>,
Bjorn Helgaas <firstname.lastname@example.org>,
Chris Metcalf <email@example.com>,
Chris Zankel <firstname.lastname@example.org>,
Tim Bird <email@example.com>
Subject: Re: [patch 0/3] Turn CONFIG_HOTPLUG always on.
Date: Fri, 5 Oct 2012 07:32:46 -0700 [thread overview]
Message-ID: <20121005143246.GA18276@kroah.com> (raw)
On Fri, Oct 05, 2012 at 01:50:36AM -0700, Andrew Morton wrote:
> On Thu, 6 Sep 2012 13:28:16 -0700 Greg KH <firstname.lastname@example.org> wrote:
> > On Tue, Sep 04, 2012 at 05:01:05PM -0700, Greg Kroah-Hartman wrote:
> > > From: Greg KH <email@example.com>
> > >
> > > The CONFIG_HOTPLUG variable is tough to turn off, and almost all arches
> > > default to it on.
> > >
> > > If you turn it off, it saves you a big 200 or so bytes, and then starts
> > > to cause all sorts of problems as the code paths if the option is
> > > disabled is never really tested, and memory segments start to get thrown
> > > away that driver authors assume will always be present.
> > >
> > > So, as part of trying to get rid of the option entirely, let's just turn
> > > the option always on.
> > >
> > > Note, to do this properly, I found two duplicate definitions of the
> > > option, in the Tile and Xtensa arch files, this patch series removes
> > > those duplicates first.
> > >
> > > Anyone object to me just taking these three patches through my
> > > driver-core tree for 3.7? After this set, I'll start unwinding the
> > > places where CONFIG_HOTPLUG is used and remove the parts that are not
> > > used anymore now that the option can not be turned off.
> > Given the lack of objection, I've now queued these up for 3.7 and will
> > start unwinding the CONFIG_HOTPLUG mess.
> I wonder if this has had sufficient consideration.
> It isn't just 200 bytes, is it? It's all memory which is marked
> __devinit* and __devexit* - that's a tremendous amount of stuff. We
> should quantify it.
> It wouldn't surprise me if there are organizations who are using
> CONFIG_HOTPLUG=n effectively. We regularly bust a gut to save a few
> bytes and for people who really care about this we're here sending them
> backwards a lot further than that.
Given the recent round of patches that I've applied to the tree making
it so that CONFIG_HOTPLUG=n actually boots and works, that were needed
for the past 6+ kernel versions, I find it very unlikely anyone actually
runs a system in this type of configuration, but I would love to hear
from someone who does if they are out there.
prev parent reply other threads:[~2012-10-05 14:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 0:01 [patch 0/3] Turn CONFIG_HOTPLUG always on Greg Kroah-Hartman
2012-09-05 0:01 ` [patch 1/3] xtensa: remove duplicate CONFIG_HOTPLUG definition Greg Kroah-Hartman
2012-09-05 0:01 ` [patch 2/3] tile: " Greg Kroah-Hartman
2012-09-05 0:56 ` Chris Metcalf
2012-09-05 0:01 ` [patch 3/3] CONFIG_HOTPLUG should be always on Greg Kroah-Hartman
2012-09-06 20:28 ` [patch 0/3] Turn CONFIG_HOTPLUG " Greg KH
2012-10-05 8:50 ` Andrew Morton
2012-10-05 14:32 ` Greg KH [this message]
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).