From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: Borislav Petkov <bp@amd64.org>, Jiri Slaby <jslaby@suse.cz>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
LKML <linux-kernel@vger.kernel.org>,
Joe Perches <joe@perches.com>
Subject: Re: [PATCH] Fix bogus "callbacks suppressed" messages
Date: Fri, 5 Oct 2012 09:06:30 -0700 [thread overview]
Message-ID: <20121005160630.GA15269@kroah.com> (raw)
In-Reply-To: <20121005154847.GB246@x4>
On Fri, Oct 05, 2012 at 05:48:47PM +0200, Markus Trippelsdorf wrote:
> On 2012.10.05 at 17:43 +0200, Borislav Petkov wrote:
> > On Fri, Oct 05, 2012 at 08:37:06AM -0700, Greg Kroah-Hartman wrote:
> > > So WARN_RATELIMIT was never working properly? If so, how far back does
> > > it go in kernel releases that this should be fixed?
> >
> > Since b3eec79b0776e which added it in May 2011. But the only one othe r
> > user is net/core/filter.c.
>
> But it doesn't matter, because the WARN_RATELIMIT in net/core/filter.c
> is guarded by a switch statement and uses WARN_RATELIMIT(1,...). So it
> could never trigger the bug.
Ok, thanks for digging that all up, I'll just merge this in for 3.7.
greg k-h
next prev parent reply other threads:[~2012-10-05 16:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 9:20 tty_init_dev: 24 callbacks suppressed Borislav Petkov
2012-10-04 11:23 ` Markus Trippelsdorf
2012-10-04 11:51 ` Markus Trippelsdorf
2012-10-04 12:40 ` Borislav Petkov
2012-10-04 13:11 ` Markus Trippelsdorf
2012-10-05 11:17 ` Jiri Slaby
2012-10-05 11:25 ` Alan Cox
2012-10-05 12:27 ` Borislav Petkov
2012-10-05 12:57 ` [PATCH] Fix bogus "callbacks suppressed" messages Markus Trippelsdorf
2012-10-05 14:26 ` Greg Kroah-Hartman
2012-10-05 15:28 ` Markus Trippelsdorf
2012-10-05 15:29 ` Borislav Petkov
2012-10-05 15:37 ` Greg Kroah-Hartman
2012-10-05 15:41 ` Markus Trippelsdorf
2012-10-05 15:43 ` Borislav Petkov
2012-10-05 15:48 ` Markus Trippelsdorf
2012-10-05 16:03 ` Borislav Petkov
2012-10-05 16:06 ` Greg Kroah-Hartman [this message]
2012-10-05 18:06 ` Jiri Slaby
2012-10-05 15:33 ` tty_init_dev: 24 callbacks suppressed Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121005160630.GA15269@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bp@amd64.org \
--cc=joe@perches.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).