From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751901Ab2JIFcC (ORCPT ); Tue, 9 Oct 2012 01:32:02 -0400 Received: from stator.leun.net ([85.214.203.199]:42981 "EHLO stator.leun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750999Ab2JIFb7 (ORCPT ); Tue, 9 Oct 2012 01:31:59 -0400 X-Greylist: delayed 907 seconds by postgrey-1.27 at vger.kernel.org; Tue, 09 Oct 2012 01:31:59 EDT Date: Tue, 9 Oct 2012 07:15:15 +0200 From: Michael Leun To: Greg KH Cc: linux@rainbow-software.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [3.5 regression / mcs7830 / bisected] bridge constantly toggeling between disabled and forwarding Message-ID: <20121009071515.607f85a4@xenia.leun.net> In-Reply-To: <20120927173905.GC21025@kroah.com> References: <20120723091504.2d035d28@xenia.leun.net> <20120724013634.11bf1360@xenia.leun.net> <20120927173905.GC21025@kroah.com> Organization: Not Organized X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; i586-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 27 Sep 2012 10:39:05 -0700 Greg KH wrote: > On Tue, Jul 24, 2012 at 01:36:34AM +0200, Michael Leun wrote: > > On Mon, 23 Jul 2012 09:15:04 +0200 > > Michael Leun wrote: > > > > [see issue description below] > > > > Bisecting yielded > > > > b1ff4f96fd1c63890d78d8939c6e0f2b44ce3113 is the first bad commit > > commit b1ff4f96fd1c63890d78d8939c6e0f2b44ce3113 > > Author: Ondrej Zary > > Date: Fri Jun 1 10:29:08 2012 +0000 > > > > mcs7830: Implement link state detection > > > > Add .status callback that detects link state changes. > > Tested with MCS7832CV-AA chip (9710:7830, identified as rev.C > > by the driver). Fixes > > https://bugzilla.kernel.org/show_bug.cgi?id=28532 > > > > Signed-off-by: Ondrej Zary > > Signed-off-by: David S. Miller > > > > :040000 040000 5480780cb5e75c57122a621fc3bab0108c16be27 > > d97efd9cc0a465dff76bcd3a3c547f718f2a5345 M drivers > > > > > > Reverting that from 3.5 makes the issue go away. > > Did this ever get resolved in 3.6-rc7 or any older kernel? I can't > revert the patch from 3.5.y unless it's also fixed in Linus's tree. Please excuse me for answering a bit late. No, that never got resolved, I still have the problem with 3.6 but I'm not shure about the correct solution. Maybe link state detection just does not work with some of that devices and we should have an possibility to enable/disable it per device, maybe it can be handeled with an blacklist of not working devices, maybe it could be fixed - I do not know and also do not know how to find out. But I'm willing to test. -- MfG, Michael Leun