linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ondrej Zary <linux@rainbow-software.org>
To: Michael Leun <lkml20120218@newton.leun.net>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	davem@davemloft.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [3.5 regression / mcs7830 / bisected] bridge constantly toggeling between disabled and forwarding
Date: Tue, 9 Oct 2012 09:07:24 +0200	[thread overview]
Message-ID: <201210090907.25018.linux@rainbow-software.org> (raw)
In-Reply-To: <20121009071515.607f85a4@xenia.leun.net>

On Tuesday 09 October 2012, Michael Leun wrote:
> On Thu, 27 Sep 2012 10:39:05 -0700
>
> Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Tue, Jul 24, 2012 at 01:36:34AM +0200, Michael Leun wrote:
> > > On Mon, 23 Jul 2012 09:15:04 +0200
> > > Michael Leun <lkml20120218@newton.leun.net> wrote:
> > >
> > > [see issue description below]
> > >
> > > Bisecting yielded
> > >
> > > b1ff4f96fd1c63890d78d8939c6e0f2b44ce3113 is the first bad commit
> > > commit b1ff4f96fd1c63890d78d8939c6e0f2b44ce3113
> > > Author: Ondrej Zary <linux@rainbow-software.org>
> > > Date:   Fri Jun 1 10:29:08 2012 +0000
> > >
> > >     mcs7830: Implement link state detection
> > >
> > >     Add .status callback that detects link state changes.
> > >     Tested with MCS7832CV-AA chip (9710:7830, identified as rev.C
> > > by the driver). Fixes
> > > https://bugzilla.kernel.org/show_bug.cgi?id=28532
> > >
> > >     Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
> > >     Signed-off-by: David S. Miller <davem@davemloft.net>
> > >
> > > :040000 040000 5480780cb5e75c57122a621fc3bab0108c16be27
> > >
> > > d97efd9cc0a465dff76bcd3a3c547f718f2a5345 M    drivers
> > >
> > >
> > > Reverting that from 3.5 makes the issue go away.
> >
> > Did this ever get resolved in 3.6-rc7 or any older kernel?  I can't
> > revert the patch from 3.5.y unless it's also fixed in Linus's tree.
>
> Please excuse me for answering a bit late.
>
> No, that never got resolved, I still have the problem with 3.6 but I'm
> not shure about the correct solution.
>
> Maybe link state detection just does not work with some of that devices
> and we should have an possibility to enable/disable it per device,
> maybe it can be handeled with an blacklist of not working devices,
> maybe it could be fixed - I do not know and also do not know how to
> find out.
>
> But I'm willing to test.

Does the problem appear only in a bridge? Or the link state detection is 
completely wrong?

-- 
Ondrej Zary

  reply	other threads:[~2012-10-09  7:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-23  7:15 [3.5 regression / bridge] constantly toggeling between disabled and forwarding Michael Leun
2012-07-23 15:02 ` Stephen Hemminger
2012-07-23 23:36 ` [3.5 regression / mcs7830 / bisected] bridge " Michael Leun
2012-07-31  5:52   ` Michael Leun
2012-09-27 17:39   ` Greg KH
2012-10-09  5:15     ` Michael Leun
2012-10-09  7:07       ` Ondrej Zary [this message]
2012-10-09  7:21       ` Ondrej Zary
2012-10-09  8:56         ` Michael Leun
2012-10-11  8:14           ` Ondrej Zary
2012-10-11  9:26             ` Michael Leun
2012-08-14 10:58 Ambroz Bizjak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201210090907.25018.linux@rainbow-software.org \
    --to=linux@rainbow-software.org \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml20120218@newton.leun.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).