linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kent Overstreet <koverstreet@google.com>
To: Zach Brown <zab@redhat.com>
Cc: linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org,
	dm-devel@redhat.com, tytso@mit.edu
Subject: Re: [PATCH 2/5] aio: kiocb_cancel()
Date: Tue, 9 Oct 2012 14:37:00 -0700	[thread overview]
Message-ID: <20121009213700.GF29494@google.com> (raw)
In-Reply-To: <20121009182625.GM26187@lenny.home.zabbo.net>

On Tue, Oct 09, 2012 at 11:26:25AM -0700, Zach Brown wrote:
> On Mon, Oct 08, 2012 at 11:39:17PM -0700, Kent Overstreet wrote:
> > Minor refactoring, to get rid of some duplicated code
> 
> Honestly: I wouldn't bother.  Nothing of consequence uses cancel.
> 
> I have an RFC patch series that tears it out.  Let me polish that up
> send it out, I'll cc: you.

Even better :)

I've been looking at aio locking the past few days, and I was getting
ready to write something up about cancellation to the lists.

Short version, supporting cancellation without global sychronization is
possible but it'd require help from the allocator.

If we can just rip it out though that'd really make me happy.

  reply	other threads:[~2012-10-09 21:37 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-09  6:39 [PATCH 1/5] aio: Kill return value of aio_complete() Kent Overstreet
2012-10-09  6:39 ` [PATCH 2/5] aio: kiocb_cancel() Kent Overstreet
2012-10-09 18:26   ` Zach Brown
2012-10-09 21:37     ` Kent Overstreet [this message]
2012-10-10 11:03       ` Theodore Ts'o
2012-10-10 21:20         ` Zach Brown
2012-10-10 23:21           ` Theodore Ts'o
2012-10-11  2:41         ` Kent Overstreet
2012-10-09  6:39 ` [PATCH 3/5] aio: Rewrite refcounting Kent Overstreet
2012-10-09 18:27   ` Zach Brown
2012-10-09 22:21     ` Kent Overstreet
2012-10-09 22:35       ` Zach Brown
2012-10-10  0:17         ` Kent Overstreet
2012-10-09  6:39 ` [PATCH 4/5] aio: vmap ringbuffer Kent Overstreet
2012-10-09 18:29   ` Zach Brown
2012-10-09 21:31     ` Kent Overstreet
2012-10-09 22:32       ` Zach Brown
2012-10-09 22:44         ` Kent Overstreet
2012-10-09 22:58           ` Zach Brown
2012-10-10  0:16             ` Kent Overstreet
2012-10-10  0:36               ` Zach Brown
2012-10-10  1:09                 ` Kent Overstreet
2012-10-09  6:39 ` [PATCH 5/5] aio: Refactor aio_read_evt, use cmxchg(), fix bug Kent Overstreet
2012-10-09 18:37   ` Zach Brown
2012-10-09 21:27     ` Kent Overstreet
2012-10-09 22:47       ` Zach Brown
2012-10-09 22:55         ` Kent Overstreet
2012-10-09 23:10           ` Zach Brown
2012-10-10  0:06             ` Kent Overstreet
2012-10-10  0:26               ` Zach Brown
2012-10-10  0:47                 ` Kent Overstreet
2012-10-10 21:43                   ` Zach Brown
2012-10-11  2:51                     ` Kent Overstreet
2012-10-11 16:43                       ` Zach Brown
2012-10-09 18:25 ` [PATCH 1/5] aio: Kill return value of aio_complete() Zach Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121009213700.GF29494@google.com \
    --to=koverstreet@google.com \
    --cc=dm-devel@redhat.com \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=zab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).