From: David Gibson <david@gibson.dropbear.id.au>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Warner Losh <imp@bsdimp.com>,
Scott Wood <scottwood@freescale.com>,
Michal Marek <mmarek@suse.cz>,
devicetree-discuss@lists.ozlabs.org,
Stephen Warren <swarren@nvidia.com>,
linux-kernel@vger.kernel.org
Subject: Re: dtc: import latest upstream dtc
Date: Thu, 11 Oct 2012 10:09:55 +1100 [thread overview]
Message-ID: <20121010230955.GF28467@truffula.fritz.box> (raw)
In-Reply-To: <50759152.9050407@wwwdotorg.org>
On Wed, Oct 10, 2012 at 09:16:34AM -0600, Stephen Warren wrote:
> On 10/10/2012 01:24 AM, David Gibson wrote:
> > On Tue, Oct 09, 2012 at 10:43:50PM -0600, Warner Losh wrote:
[snip]
> >> .h files include both structs and defines, which are fine for
> >> ordinary C code, but problematic in this context.
> >
> > Right, cpp should be invoked with similar options to the way it's done
> > for asm files which have the same problem. I'm not sure if the
> > current patch does so.
>
> That's probably a reasonable idea, although I imagined that people would
> actually split out the portions of any header file they wanted to use
> with dtc, so that any headers included by *.dts would only include
> #defines. Those headers could be used by both dtc and other .h files (or
> .c files).
Given that header files are right now frequently used in both .c and
.S for the #defines, I don't think we can reasonably expect
differently for dts files. There certainly is the potential for
#include dependency mess, but we cope with it for .S so we can cope
with it for dts as well.
But cpp should definitely be invoked "asm style" for dts files.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2012-10-11 0:28 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 21:25 [PATCH] dtc: import latest upstream dtc Stephen Warren
2012-09-29 21:06 ` Jon Loeliger
2012-10-01 16:09 ` Rob Herring
2012-10-01 16:13 ` Stephen Warren
2012-10-01 17:56 ` Rob Herring
2012-10-01 18:33 ` Stephen Warren
2012-10-01 18:39 ` Jon Loeliger
2012-10-09 21:16 ` Stephen Warren
2012-10-09 23:20 ` Mitch Bradley
2012-10-10 0:04 ` Scott Wood
2012-10-10 4:43 ` Warner Losh
2012-10-10 7:24 ` David Gibson
2012-10-10 14:41 ` Warner Losh
2012-10-10 23:06 ` David Gibson
2012-10-10 15:16 ` Stephen Warren
2012-10-10 15:33 ` Rob Herring
2012-10-10 16:19 ` Stephen Warren
2012-10-10 17:18 ` Rob Herring
2012-10-10 18:42 ` Stephen Warren
2012-10-10 23:16 ` David Gibson
2012-10-11 1:42 ` Mitch Bradley
2012-10-11 5:11 ` David Gibson
2012-10-10 23:09 ` David Gibson [this message]
2012-10-10 15:15 ` Stephen Warren
2012-10-10 16:09 ` Scott Wood
2012-10-10 16:22 ` Stephen Warren
2012-10-10 23:18 ` David Gibson
2012-10-12 17:24 ` Stephen Warren
2012-10-13 6:24 ` David Gibson
2012-10-13 13:42 ` Segher Boessenkool
2012-10-14 0:16 ` David Gibson
2012-10-10 17:09 ` Rob Herring
2012-10-10 18:23 ` Mitch Bradley
2012-10-10 18:45 ` Stephen Warren
2012-10-10 18:56 ` Mitch Bradley
2012-10-11 0:14 ` David Gibson
2012-10-10 23:54 ` David Gibson
2012-10-10 18:40 ` Stephen Warren
2012-10-10 18:52 ` Mitch Bradley
2012-10-01 18:02 ` Jon Loeliger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121010230955.GF28467@truffula.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=imp@bsdimp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=scottwood@freescale.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).