linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Ashish Jangam <ashish.jangam@kpitcummins.com>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
	Samuel Ortiz <sameo@linux.intel.com>,
	linux-input@vger.kernel.org, David Dajun Chen <dchen@diasemi.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [Patch v3 7/7] Onkey: DA9055 Onkey driver
Date: Thu, 11 Oct 2012 09:28:53 -0700	[thread overview]
Message-ID: <20121011162852.GB15588@core.coreip.homeip.net> (raw)
In-Reply-To: <1349952316.9228.7.camel@dhruva>

Hi Ashish,

On Thu, Oct 11, 2012 at 04:15:16PM +0530, Ashish Jangam wrote:
> This is the ONKEY driver of the Dialog DA9055 PMIC and depends on the DA9055 MFD
> core driver.
> 
> This patch is functionally tested on SMDK6410 board.
> 
> Signed-off-by: David Dajun Chen <dchen@diasemi.com>
> Signed-off-by: Ashish Jangam <ashish.jangam@kpitcummins.com>
> ---
> changes since v3:
> - used of module_platform_driver macro
> - add regmap virtual irq function
> changes since v2:
> - add support for button release
> - use of devm_request_threaded_irq API

This API does not make any sense for your driver as you are scheduling
delayed work from the IRQ handler. In such cases you need _first_ free
IRQ and _then_ cancel the work but with devm_* you do it in opposite
order.

Also, I think I mentioned this before - this driver looks like twin
brother for da9055_onkey.c. How many of such parts do you have (or will
you have)? Is there way to unify them?

Thanks.

-- 
Dmitry

  reply	other threads:[~2012-10-11 16:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-11 10:45 [Patch v3 7/7] Onkey: DA9055 Onkey driver Ashish Jangam
2012-10-11 16:28 ` Dmitry Torokhov [this message]
2012-10-12  6:46   ` Ashish Jangam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121011162852.GB15588@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=ashish.jangam@kpitcummins.com \
    --cc=dchen@diasemi.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).