From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756337Ab2JRV4N (ORCPT ); Thu, 18 Oct 2012 17:56:13 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:62240 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755361Ab2JRV4M (ORCPT ); Thu, 18 Oct 2012 17:56:12 -0400 Date: Thu, 18 Oct 2012 14:56:07 -0700 From: Tejun Heo To: Michal Hocko Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Li Zefan , Johannes Weiner , KAMEZAWA Hiroyuki , Balbir Singh Subject: Re: [PATCH 1/6] memcg: split mem_cgroup_force_empty into reclaiming and reparenting parts Message-ID: <20121018215607.GN13370@google.com> References: <1350480648-10905-1-git-send-email-mhocko@suse.cz> <1350480648-10905-2-git-send-email-mhocko@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1350480648-10905-2-git-send-email-mhocko@suse.cz> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 17, 2012 at 03:30:43PM +0200, Michal Hocko wrote: > mem_cgroup_force_empty did two separate things depending on free_all > parameter from the very beginning. It either reclaimed as many pages as > possible and moved the rest to the parent or just moved charges to the > parent. The first variant is used as memory.force_empty callback while > the later is used from the mem_cgroup_pre_destroy. > > The whole games around gotos are far from being nice and there is no > reason to keep those two functions inside one. Let's split them and > also move the responsibility for css reference counting to their callers > to make to code easier. > > This patch doesn't have any functional changes. > > Signed-off-by: Michal Hocko Reviewed-by: Tejun Heo Thanks. -- tejun