From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
devel@driverdev.osuosl.org,
linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/1] staging: Add firewire-serial driver
Date: Tue, 23 Oct 2012 10:51:40 +0100 [thread overview]
Message-ID: <20121023105140.5996c3a5@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <1350959679.2621.55.camel@thor>
> 1. The ldisc drops the contents of tty_buffer on hangup (rather than
> waiting for completion). Maybe for other devices this isn't so
> noticeable because the ldisc can mostly keep up with the device, but on
> firewire the ldisc lags well behind. Right now, this driver works around
> this by holding off the hangup until the ldisc empties the tty_buffer.
> The driver determines how much data is still left in the tty_buffer by
> walking the flip buffers.
The driver should not be trying to look at this, so it's good that it
broke now. If you need it to process the data on then hangup then the
core code wants fixing to allow this to occur.
> 2. Because this driver can fill the entire tty_buffer (64K +) before the
> ldisc even runs once, this driver has to self-throttle when feeding the
> tty_buffer.
That wants investigating properly. We do multiple megabits quite happily
via the tty layer with 3G modems over USB. What is your data rate ?
Again it wants dealing with properly.
Alan
next prev parent reply other threads:[~2012-10-23 9:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 12:56 [PATCH 0/1] staging: Add firewire-serial driver Peter Hurley
2012-10-22 22:45 ` Greg Kroah-Hartman
2012-10-23 2:34 ` Peter Hurley
2012-10-23 3:15 ` Greg Kroah-Hartman
2012-10-23 9:51 ` Alan Cox [this message]
2012-10-23 16:30 ` Peter Hurley
2012-10-23 18:41 ` Stefan Richter
2012-10-24 13:41 ` Stefan Richter
2012-10-24 15:56 ` Peter Hurley
2012-11-02 12:16 ` [PATCH v2 " Peter Hurley
2012-11-02 12:16 ` [PATCH v2 1/1] staging: fwserial: Add TTY-over-Firewire serial driver Peter Hurley
2012-11-12 23:33 ` Stefan Richter
2012-11-12 23:51 ` Greg Kroah-Hartman
2012-11-13 19:37 ` Peter Hurley
2012-11-13 19:47 ` Greg Kroah-Hartman
2012-11-13 19:14 ` Peter Hurley
2012-11-14 1:25 ` Stefan Richter
2012-11-27 18:33 ` Peter Hurley
2012-11-27 23:58 ` Stefan Richter
2012-11-28 1:00 ` Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121023105140.5996c3a5@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=peter@hurleysoftware.com \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).