From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757475Ab2JWTyS (ORCPT ); Tue, 23 Oct 2012 15:54:18 -0400 Received: from violet.fr.zoreil.com ([92.243.8.30]:49223 "EHLO violet.fr.zoreil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756884Ab2JWTyR (ORCPT ); Tue, 23 Oct 2012 15:54:17 -0400 Date: Tue, 23 Oct 2012 21:33:04 +0200 From: Francois Romieu To: Hayes Wang Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 net-next 1/2] r8169: enable ALDPS for power saving Message-ID: <20121023193304.GB10463@electric-eye.fr.zoreil.com> References: <1350893153-18320-1-git-send-email-hayeswang@realtek.com> <1350974831-1438-1-git-send-email-hayeswang@realtek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1350974831-1438-1-git-send-email-hayeswang@realtek.com> User-Agent: Mutt/1.4.2.2i X-Organisation: Land of Sunshine Inc. Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hayes Wang : > Enable ALDPS function to save power when link down. Note that the > feature should be set after the other PHY settings. And the firmware > is necessary. Don't enable it without loading the firmware. > > Signed-off-by: Hayes Wang [...] Please see my just sent answer in yesterday's thread. > +static void r810x_aldps_disable(struct rtl8169_private *tp) > +{ > + rtl_writephy(tp, 0x1f, 0x0000); > + rtl_writephy(tp, 0x18, 0x0310); > + msleep(100); > +} rtl8402_hw_phy_config used a msleep(20). Meguesses it won't hurt, right ? [...] > + > + /* ALDPS enable */ > + r8168_aldps_enable_1(tp); The functions are literate enough: you can remove the comment. [...] > @@ -6391,6 +6431,8 @@ static void rtl8169_net_suspend(struct net_device *dev) > { > struct rtl8169_private *tp = netdev_priv(dev); > > + tp->features &= ~RTL_FEATURE_EXTENDED; > + > if (!netif_running(dev)) > return; No (as previously stated). -- Ueimor