From: Greg KH <gregkh@linuxfoundation.org>
To: Anmol Sarma <unmole.in@gmail.com>
Cc: devel@driverdev.osuosl.org, swetland@google.com,
arve@android.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: android: binder: Fixed multi-line strings
Date: Tue, 23 Oct 2012 21:13:35 -0700 [thread overview]
Message-ID: <20121024041335.GA25336@kroah.com> (raw)
In-Reply-To: <20121023094335.GA13929@gmail.com>
On Tue, Oct 23, 2012 at 03:13:38PM +0530, Anmol Sarma wrote:
> >From 949ecac6fcd58ffa6d02f6761058dbcfb1c2ba42 Mon Sep 17 00:00:00 2001
> From: Anmol Sarma <unmole.in@gmail.com>
> Date: Tue, 23 Oct 2012 13:47:14 +0530
> Subject: [PATCH] Staging: android: binder: Strings cleanup
>
> Changed all user visible multi-line stings to single line.
No you didn't:
> @@ -420,12 +422,12 @@ static void binder_set_nice(long nice)
> }
> min_nice = 20 - current->signal->rlim[RLIMIT_NICE].rlim_cur;
> binder_debug(BINDER_DEBUG_PRIORITY_CAP,
> - "binder: %d: nice value %ld not allowed use "
> + "%d: nice value %ld not allowed use "
> "%ld instead\n", current->pid, nice, min_nice);
That's a multi-line string :(
And you sent 2 copies of this patch, why?
Care to try again?
greg k-h
next prev parent reply other threads:[~2012-10-24 4:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 19:01 [PATCH] Staging: android: binder: Fixed multi-line strings Anmol Sarma
2012-10-08 23:15 ` Joe Perches
2012-10-22 20:02 ` Greg KH
2012-10-23 9:43 ` Anmol Sarma
2012-10-24 4:13 ` Greg KH [this message]
2012-10-24 7:58 ` Anmol Sarma
2012-10-24 22:29 ` Greg KH
2012-10-25 8:06 ` Anmol Sarma
2012-10-25 19:25 ` Greg KH
2012-10-26 7:26 ` Anmol Sarma
2012-10-26 8:24 ` Anmol Sarma
2012-10-29 21:53 ` Greg KH
2012-10-30 17:05 ` Anmol Sarma
2012-10-09 8:29 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121024041335.GA25336@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swetland@google.com \
--cc=unmole.in@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).