From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161149Ab2JXTFz (ORCPT ); Wed, 24 Oct 2012 15:05:55 -0400 Received: from mail.skyhub.de ([78.46.96.112]:54488 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965086Ab2JXTFv (ORCPT ); Wed, 24 Oct 2012 15:05:51 -0400 Date: Wed, 24 Oct 2012 21:05:46 +0200 From: Borislav Petkov To: danielfsantos@att.net Cc: LKML , Andi Kleen , Andrea Arcangeli , Andrew Morton , Christopher Li , Daniel Santos , David Daney , David Howells , Joe Perches , Josh Triplett , Konstantin Khlebnikov , linux-sparse@vger.kernel.org, Michel Lespinasse , Paul Gortmaker , Pavel Pisa , Peter Zijlstra , Steven Rostedt , David Rientjes Subject: Re: [PATCH v3 03/10] compiler-gcc{3,4}.h: Use GCC_VERSION macro Message-ID: <20121024190546.GA17945@liondog.tnic> Mail-Followup-To: Borislav Petkov , danielfsantos@att.net, LKML , Andi Kleen , Andrea Arcangeli , Andrew Morton , Christopher Li , Daniel Santos , David Daney , David Howells , Joe Perches , Josh Triplett , Konstantin Khlebnikov , linux-sparse@vger.kernel.org, Michel Lespinasse , Paul Gortmaker , Pavel Pisa , Peter Zijlstra , Steven Rostedt , David Rientjes References: <1351096132-12244-1-git-send-email-daniel.santos@pobox.com> <1351096441-12388-3-git-send-email-daniel.santos@pobox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1351096441-12388-3-git-send-email-daniel.santos@pobox.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 24, 2012 at 11:33:54AM -0500, danielfsantos@att.net wrote: > Using GCC_VERSION reduces complexity, is easier to read and is GCC's > recommended mechanism for doing version checks. (Just don't ask me why > they didn't define it in the first place.) This also makes it easy to > merge compiler-gcc{,3,4}.h should somebody want to. > > Signed-off-by: Daniel Santos > Acked-by: David Rientjes > --- > include/linux/compiler-gcc3.h | 8 ++++---- > include/linux/compiler-gcc4.h | 14 +++++++------- > 2 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/include/linux/compiler-gcc3.h b/include/linux/compiler-gcc3.h > index 37d4124..7d89feb 100644 > --- a/include/linux/compiler-gcc3.h > +++ b/include/linux/compiler-gcc3.h > @@ -2,22 +2,22 @@ > #error "Please don't include directly, include instead." > #endif > > -#if __GNUC_MINOR__ < 2 > +#if GCC_VERSION < 30200 > # error Sorry, your compiler is too old - please upgrade it. > #endif > > -#if __GNUC_MINOR__ >= 3 > +#if GCC_VERSION >= 30300 > # define __used __attribute__((__used__)) > #else > # define __used __attribute__((__unused__)) > #endif > > -#if __GNUC_MINOR__ >= 4 > +#if GCC_VERSION >= 30400 > #define __must_check __attribute__((warn_unused_result)) > #endif > > #ifdef CONFIG_GCOV_KERNEL > -# if __GNUC_MINOR__ < 4 > +# if GCC_VERSION < 30400 > # error "GCOV profiling support for gcc versions below 3.4 not included" > # endif /* __GNUC_MINOR__ */ > #endif /* CONFIG_GCOV_KERNEL */ > diff --git a/include/linux/compiler-gcc4.h b/include/linux/compiler-gcc4.h > index 8914293..9755029 100644 > --- a/include/linux/compiler-gcc4.h > +++ b/include/linux/compiler-gcc4.h > @@ -4,7 +4,7 @@ > > /* GCC 4.1.[01] miscompiles __weak */ > #ifdef __KERNEL__ > -# if __GNUC_MINOR__ == 1 && __GNUC_PATCHLEVEL__ <= 1 > +# if GCC_VERSION >= 40100 && GCC_VERSION <= 40101 > # error Your version of gcc miscompiles the __weak directive > # endif > #endif > @@ -13,11 +13,11 @@ > #define __must_check __attribute__((warn_unused_result)) > #define __compiler_offsetof(a,b) __builtin_offsetof(a,b) > > -#if __GNUC_MINOR__ > 0 > +#if GCC_VERSION >= 40100 I can't seem to recall so did we explain already why ">= 40100" instead of "> 40000"? I mean, it is the same, but still... Thanks. -- Regards/Gruss, Boris.