From: Joel Becker <jlbec@evilplan.org>
To: Marco Stornelli <marco.stornelli@gmail.com>
Cc: Linux FS Devel <linux-fsdevel@vger.kernel.org>,
Mark Fasheh <mfasheh@suse.com>,
ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/21] ocfs2: drop vmtruncate
Date: Wed, 24 Oct 2012 17:18:23 -0700 [thread overview]
Message-ID: <20121025001822.GC3140@localhost> (raw)
In-Reply-To: <CANGUGtAiktPm5J+yViNhEN+udU60Z+JH+4bEozwHxeXe2Oec6w@mail.gmail.com>
On Tue, Oct 23, 2012 at 02:48:38PM +0200, Marco Stornelli wrote:
> 2012/10/23 Joel Becker <jlbec@evilplan.org>:
> > On Tue, Oct 23, 2012 at 10:58:42AM +0200, Marco Stornelli wrote:
> >> 2012/10/23 Joel Becker <jlbec@evilplan.org>:
> >> > On Sat, Oct 20, 2012 at 02:19:00PM +0200, Marco Stornelli wrote:
> >> >> Removed vmtruncate
> >> >>
> >> >> Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
> >> >
> >> > Acked-by: Joel Becker <jlbec@evilplan.org>
> >> >
> >> > Do you want me to pull this, or are you going to send it with your set?
> >> >
> >> > Joel
> >> >
> >>
> >> I'd prefer to push all via Al's tree since there is a VFS change.
> >
> > SGTM. Thanks!
> >
> > Joel
> >
>
> I've got a doubt and I ask to ocfs2 expert :) It seems i_size_write()
> and truncate_inode_pages() and so on, they are already called in each
> path of setattr for a size change, so maybe we can remove
> truncate_setsize() and simply to remove the vmtuncate code, can you
> give me your opinion?
Actually, I have to revisit this, because Chrisoph points out
your adjusting i_size outside of a transaction.
Joel
> Thanks.
>
> Marco
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
"Practice random acts of kindness and senseless acts of beauty."
Oh, and don't forget where your towel is.
http://www.jlbec.org/
jlbec@evilplan.org
next prev parent reply other threads:[~2012-10-25 0:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-20 12:19 [PATCH 06/21] ocfs2: drop vmtruncate Marco Stornelli
2012-10-23 8:54 ` Joel Becker
2012-10-23 8:58 ` Marco Stornelli
2012-10-23 9:02 ` Joel Becker
2012-10-23 12:48 ` Marco Stornelli
2012-10-25 0:18 ` Joel Becker [this message]
2012-10-25 6:37 ` Marco Stornelli
2012-10-23 13:02 ` Christoph Hellwig
2012-10-25 0:17 ` Joel Becker
-- strict thread matches above, loose matches on Subject: below --
2012-12-15 10:50 Marco Stornelli
2012-11-03 9:25 Marco Stornelli
2012-08-31 13:54 Marco Stornelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121025001822.GC3140@localhost \
--to=jlbec@evilplan.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
--cc=mfasheh@suse.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).