From: Feng Tang <feng.tang@intel.com>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>, Namhyung Kim <namhyung@kernel.org>,
Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 7/8] perf hists browser: Add option for runtime switching perf data file
Date: Wed, 31 Oct 2012 00:01:49 +0800 [thread overview]
Message-ID: <20121030160149.GA14234@feng-snb> (raw)
In-Reply-To: <20121029140620.GD6754@infradead.org>
Hi Arnaldo,
Thanks for the review.
On Mon, Oct 29, 2012 at 12:06:20PM -0200, Arnaldo Carvalho de Melo wrote:
> Em Tue, Oct 30, 2012 at 11:56:08AM +0800, Feng Tang escreveu:
> > + pwd_dir = opendir(pwd);
> > + if (!pwd_dir)
> > + return ret;
> > +
> > + memset(options, 0, sizeof(options));
> > + memset(options, 0, sizeof(abs_path));
> > +
> > + while ((dent = readdir(pwd_dir))) {
> > + char path[PATH_MAX];
> > + u64 magic;
> > + char *name = dent->d_name;
> > + FILE *file;
> > +
> > + if (!(dent->d_type == DT_REG))
> > + continue;
> > +
> > + snprintf(path, PATH_MAX, "%s/%s", pwd, name);
> > +
> > + file = fopen(path, "r");
> > + if (!file)
> > + continue;
> > +
> > + if (fread(&magic, 1, 8, file) < 8)
> > + goto close_file_and_continue;
> > +
> > + if (is_perf_magic(magic)) {
> > + options[nr_options] = strdup(name);
> > + if (!options[nr_options])
> > + goto close_file_and_continue;
>
> Silently not offering a valid file? At this point I think you should
> warn the user and bail out.
Yeah, we should give a warning message and go on with the valid data
files already got.
> > +
> > + abs_path[nr_options] = strdup(path);
> > + if (!abs_path[nr_options]) {
> > + free(options[nr_options]);
> > + goto close_file_and_continue;
> > + }
> > +
> > + nr_options++;
> > + }
> > +
> > +close_file_and_continue:
> > + fclose(file);
> > + if (nr_options >= 256)
> > + break;
>
> Why is this? At the very least a warning has to be given to the user
> that way too many perf.data files are present, so only the first N are
> in the menu.
Ok.
> > + }
> > + closedir(pwd_dir);
> > +
> > + if (nr_options) {
> > + choice = ui__popup_menu(nr_options, options);
> > + if (choice < nr_options && choice >= 0) {
> > + tmp = strdup(abs_path[choice]);
> > + if (tmp) {
> > + if (is_input_name_malloced)
> > + free((void *)input_name);
> > + input_name = tmp;
> > + is_input_name_malloced = true;
> > + ret = 0;
> > + }
>
> Here you return an error, but will the user get any warning on the
> caller of this function if it returns -1?
>
>
> > + /* Switch to another data file */
> > + else if (choice == switch_data) {
> > +do_data_switch:
> > + if (!switch_data_file()) {
> > + key = K_SWITCH_INPUT_DATA;
> > + break;
> > + }
> > + }
>
> ... no, so it will silently continue and the user will get confused.
>
Yes, I will add more ui_warning() in these error/problematic path
Thanks,
Feng
next prev parent reply other threads:[~2012-10-29 16:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 3:56 [PATCH v5 0/8] perf tools: Add script browser and runtime data file switch Feng Tang
2012-10-30 3:56 ` [PATCH v5 1/8] perf tool: Add a global variable "const char *input_name" Feng Tang
2012-10-30 12:05 ` [tip:perf/core] perf tools: Add a global variable " const " tip-bot for Feng Tang
2012-10-30 3:56 ` [PATCH v5 2/8] perf script: Add more filter to find_scripts() Feng Tang
2012-10-30 12:06 ` [tip:perf/core] " tip-bot for Feng Tang
2012-10-30 3:56 ` [PATCH v5 3/8] perf ui/browser: Add a browser for perf script Feng Tang
2012-10-30 12:07 ` [tip:perf/core] perf scripts browser: " tip-bot for Feng Tang
2012-10-30 3:56 ` [PATCH v5 4/8] perf ui/browser: Integrate script browser into annotation browser Feng Tang
2012-10-30 12:08 ` [tip:perf/core] perf annotate browser: " tip-bot for Feng Tang
2012-10-30 3:56 ` [PATCH v5 5/8] perf ui/browser: Integrate script browser into main hists browser Feng Tang
2012-10-29 14:54 ` Arnaldo Carvalho de Melo
2012-10-30 16:05 ` Feng Tang
2012-10-30 12:09 ` [tip:perf/core] perf hists browser: " tip-bot for Feng Tang
2012-10-30 3:56 ` [PATCH v5 6/8] perf header: Add is_perf_magic() func Feng Tang
2012-10-30 12:10 ` [tip:perf/core] " tip-bot for Feng Tang
2012-10-30 3:56 ` [PATCH v5 7/8] perf hists browser: Add option for runtime switching perf data file Feng Tang
2012-10-29 14:06 ` Arnaldo Carvalho de Melo
2012-10-30 16:01 ` Feng Tang [this message]
2012-10-30 3:56 ` [PATCH v5 8/8] perf report: Enable the runtime switching of " Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121030160149.GA14234@feng-snb \
--to=feng.tang@intel.com \
--cc=acme@redhat.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).