From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Omar Ramirez Luna <omar.luna@linaro.org>,
Ohad Ben-Cohen <ohad@wizery.com>,
devel@driverdev.osuosl.org, linux-omap@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>,
Arnd Bergmann <arnd@arndb.de>, Juan Gutierrez <jgutierrez@ti.com>,
linux-kernel@vger.kernel.org,
Felipe Contreras <felipe.contreras@nokia.com>,
Suman Anna <s-anna@ti.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: OMAP2+: move mailbox.h out of plat-omap headers
Date: Tue, 30 Oct 2012 14:02:13 -0700 [thread overview]
Message-ID: <20121030210213.GA6098@kroah.com> (raw)
In-Reply-To: <20121030162441.GF11908@atomide.com>
On Tue, Oct 30, 2012 at 09:24:42AM -0700, Tony Lindgren wrote:
> * Omar Ramirez Luna <omar.luna@linaro.org> [121030 05:20]:
> > Tony,
> >
> > On 29 October 2012 12:52, Tony Lindgren <tony@atomide.com> wrote:
> > >> --- /dev/null
> > >> +++ b/include/linux/platform_data/omap_mailbox.h
> > >> @@ -0,0 +1,105 @@
> > >
> > > This file should only contain pure platform data needed
> > > by the core omap code to pass to the mailbox driver.
> >
> > Ok, looking at it closely, this header file is related to the API
> > itself, there is nothing that could be actually considered as pure
> > platform data, the structures are related with the mailbox framework
> > and even if I split this file into two, the additional header would
> > end up including the "platform_data" header unless I move
> > save/restore_ctx functions and then export them as symbols for the
> > API.
> >
> > So, it might be better for the entire file to sit in
> > linux/include/mailbox/ then.
>
> OK to me.
>
> > > The mailbox API header should be somewhere else,
> > > like include/linux/mailbox/mailbox-omap.h or similar.
> >
> > Ok.
> >
> > > But shouldn't this all now be handled by using the
> > > remoteproc framework?
> >
> > Remoteproc doesn't handle the mailbox hardware directly, it still
> > relies in the mailbox framework for the low level communications.
> > E.g.: Proc1 has a message (virtqueue msg) queued to Proc2, uses
> > mailbox msg to generate an interrupt to Proc2, Proc2 queries the
> > message (virtqueue) based on the mailbox message received.
>
> OK.
>
> Greg, do these patches look OK to you to move to live under
> drivers/mailbox?
Um, I don't know, I wasn't paying attention here, sorry.
greg k-h
next prev parent reply other threads:[~2012-10-30 21:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-29 17:06 [PATCH 0/2] ARM: OMAP: mailbox out of plat code Omar Ramirez Luna
2012-10-29 17:06 ` [PATCH 1/2] ARM: OMAP2+: move mailbox.h out of plat-omap headers Omar Ramirez Luna
2012-10-29 17:52 ` Tony Lindgren
2012-10-30 12:18 ` Omar Ramirez Luna
2012-10-30 16:24 ` Tony Lindgren
2012-10-30 21:02 ` Greg Kroah-Hartman [this message]
2012-10-31 7:22 ` Omar Ramirez Luna
2012-10-31 8:45 ` Loic PALLARDY
2012-10-31 18:24 ` Tony Lindgren
2012-10-29 17:06 ` [PATCH 2/2] mailbox: OMAP: introduce mailbox framework Omar Ramirez Luna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121030210213.GA6098@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=devel@driverdev.osuosl.org \
--cc=felipe.contreras@nokia.com \
--cc=jgutierrez@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=ohad@wizery.com \
--cc=omar.luna@linaro.org \
--cc=s-anna@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).