From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752234Ab2KHOmq (ORCPT ); Thu, 8 Nov 2012 09:42:46 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:45127 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751813Ab2KHOmo (ORCPT ); Thu, 8 Nov 2012 09:42:44 -0500 Date: Thu, 8 Nov 2012 06:42:39 -0800 From: Tejun Heo To: Michal Hocko Cc: lizefan@huawei.com, rjw@sisk.pl, containers@lists.linux-foundation.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, fweisbec@gmail.com Subject: Re: [PATCH 7/9] cgroup_freezer: introduce CGROUP_FREEZING_[SELF|PARENT] Message-ID: <20121108144239.GF12973@htj.dyndns.org> References: <1351931915-1701-1-git-send-email-tj@kernel.org> <1351931915-1701-8-git-send-email-tj@kernel.org> <20121108124755.GG31821@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121108124755.GG31821@dhcp22.suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Thu, Nov 08, 2012 at 01:47:55PM +0100, Michal Hocko wrote: > On Sat 03-11-12 01:38:33, Tejun Heo wrote: > > Introduce FREEZING_SELF and FREEZING_PARENT and make FREEZING OR of > > the two flags. This is to prepare for full hierarchy support. > > > > freezer_apply_date() is updated such that it can handle setting and > > clearing of both flags. The two flags are also exposed to userland > > via read-only files self_freezing and parent_freezing. > > > > Other than the added cgroupfs files, this patch doesn't introduce any > > behavior change. > > OK, I can imagine that this might be useful to find the first parent > group that needs to be thawed to unfreeze the group I am interested > in. Could you also update Documentation/cgroups/freezer-subsystem.txt to > clarify the intended usage? Ooh, right. Will update the doc in the last patch. > Minor nit. Same as mentioned in the previous patch freezer_apply_state > should get enum freezer_state_flags state parameter. But it isn't an enum value. Thanks. -- tejun