From: Marcelo Tosatti <mtosatti@redhat.com>
To: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Cc: Avi Kivity <avi@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
KVM <kvm@vger.kernel.org>
Subject: Re: [PATCH 2/5] KVM: MMU: simplify mmu_set_spte
Date: Mon, 12 Nov 2012 21:12:23 -0200 [thread overview]
Message-ID: <20121112231223.GC5798@amt.cnet> (raw)
In-Reply-To: <5097ACA0.7080408@linux.vnet.ibm.com>
On Mon, Nov 05, 2012 at 08:10:08PM +0800, Xiao Guangrong wrote:
> In order to detecting spte remapping, we can simply check whether the
> spte has already been pointing to the pfn even if the spte is not the
> last spte for middle spte is pointing to the kernel pfn which can not
> be mapped to userspace
>
> Also, update slot and stat.lpages iff the spte is not remapped
>
> Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
> ---
> arch/x86/kvm/mmu.c | 40 +++++++++++++---------------------------
> 1 files changed, 13 insertions(+), 27 deletions(-)
>
> diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
> index 692ebb1..4ea731e 100644
> --- a/arch/x86/kvm/mmu.c
> +++ b/arch/x86/kvm/mmu.c
> @@ -2420,8 +2420,7 @@ static void mmu_set_spte(struct kvm_vcpu *vcpu, u64 *sptep,
> pfn_t pfn, bool speculative,
> bool host_writable)
> {
> - int was_rmapped = 0;
> - int rmap_count;
> + bool was_rmapped = false;
>
> pgprintk("%s: spte %llx access %x write_fault %d"
> " user_fault %d gfn %llx\n",
> @@ -2429,25 +2428,13 @@ static void mmu_set_spte(struct kvm_vcpu *vcpu, u64 *sptep,
> write_fault, user_fault, gfn);
>
> if (is_rmap_spte(*sptep)) {
> - /*
> - * If we overwrite a PTE page pointer with a 2MB PMD, unlink
> - * the parent of the now unreachable PTE.
> - */
> - if (level > PT_PAGE_TABLE_LEVEL &&
> - !is_large_pte(*sptep)) {
> - struct kvm_mmu_page *child;
> - u64 pte = *sptep;
> + if (pfn != spte_to_pfn(*sptep)) {
> + struct kvm_mmu_page *sp = page_header(__pa(sptep));
>
> - child = page_header(pte & PT64_BASE_ADDR_MASK);
> - drop_parent_pte(child, sptep);
> - kvm_flush_remote_tlbs(vcpu->kvm);
How come its safe to drop this case?
next prev parent reply other threads:[~2012-11-12 23:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 12:09 [PATCH 1/5] KVM: MMU: cleanup mapping-level Xiao Guangrong
2012-11-05 12:10 ` [PATCH 2/5] KVM: MMU: simplify mmu_set_spte Xiao Guangrong
2012-11-12 23:12 ` Marcelo Tosatti [this message]
2012-11-13 8:39 ` Xiao Guangrong
2012-11-20 22:18 ` Marcelo Tosatti
2012-11-20 23:23 ` Xiao Guangrong
2012-11-20 23:51 ` Marcelo Tosatti
2012-11-21 3:19 ` Xiao Guangrong
2012-11-05 12:11 ` [PATCH 3/5] KVM: MMU: simplify set_spte Xiao Guangrong
2012-11-20 22:24 ` Marcelo Tosatti
2012-11-20 23:26 ` Xiao Guangrong
2012-11-05 12:12 ` [PATCH 4/5] KVM: MMU: move adjusting softmmu pte access to FNAME(page_fault) Xiao Guangrong
2012-11-20 22:27 ` Marcelo Tosatti
2012-11-20 23:28 ` Xiao Guangrong
2012-11-05 12:12 ` [PATCH 5/5] KVM: MMU: remove pt_access in mmu_set_spte Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121112231223.GC5798@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).