From: Dong Aisheng <b29396@freescale.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Shawn Guo <shawn.guo@linaro.org>,
Dong Aisheng <dong.aisheng@linaro.org>,
Devendra Naga <devendra.aaru@gmail.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: imx: Fix the logic checking if not able to find pin reg map
Date: Tue, 13 Nov 2012 14:37:30 +0800 [thread overview]
Message-ID: <20121113063729.GA11892@b29396-Latitude-E6410> (raw)
In-Reply-To: <1352768407.19229.1.camel@phoenix>
On Tue, Nov 13, 2012 at 09:00:07AM +0800, Axel Lin wrote:
> Current code sets "pin_reg = &info->pin_regs[i];" in each loop iteration,
> so in the case of no-match, pin_reg is not NULL.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Thanks for the fix.
Acked-by: Dong Aisheng <dong.aisheng@linaro.org>
Regards
Dong Aisheng
> ---
> drivers/pinctrl/pinctrl-imx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-imx.c b/drivers/pinctrl/pinctrl-imx.c
> index f3d2384..525a2c8 100644
> --- a/drivers/pinctrl/pinctrl-imx.c
> +++ b/drivers/pinctrl/pinctrl-imx.c
> @@ -71,7 +71,7 @@ static const struct imx_pin_reg *imx_find_pin_reg(
> break;
> }
>
> - if (!pin_reg) {
> + if (i == info->npin_regs) {
> dev_err(info->dev, "Pin(%s): unable to find pin reg map\n",
> info->pins[pin].name);
> return NULL;
> --
> 1.7.9.5
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2012-11-13 6:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 1:00 [PATCH] pinctrl: imx: Fix the logic checking if not able to find pin reg map Axel Lin
2012-11-13 6:37 ` Dong Aisheng [this message]
2012-11-15 11:04 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121113063729.GA11892@b29396-Latitude-E6410 \
--to=b29396@freescale.com \
--cc=axel.lin@ingics.com \
--cc=devendra.aaru@gmail.com \
--cc=dong.aisheng@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).