From: Wolfram Sang <w.sang@pengutronix.de>
To: Andreas Larsson <andreas@gaisler.com>
Cc: Ben Dooks <ben-linux@fluff.org>,
Peter Korsgaard <jacmet@sunsite.dk>,
linux-i2c@vger.kernel.org,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, software@gaisler.com
Subject: Re: [PATCH v2 1/2] i2c: i2c-ocores: Add irq support for sparc
Date: Tue, 13 Nov 2012 12:10:55 +0100 [thread overview]
Message-ID: <20121113111055.GF23119@pengutronix.de> (raw)
In-Reply-To: <1352739591-1317-2-git-send-email-andreas@gaisler.com>
[-- Attachment #1: Type: text/plain, Size: 2157 bytes --]
Hi,
On Mon, Nov 12, 2012 at 05:59:50PM +0100, Andreas Larsson wrote:
> Add sparc support by using platform_get_irq instead of platform_get_resource.
> There are no platform resources of type IORESOURCE_IRQ for sparc, but
> platform_get_irq works for sparc. In the non-sparc case platform_get_irq
> internally uses platform_get_resource.
>
> Signed-off-by: Andreas Larsson <andreas@gaisler.com>
> Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
> ---
> Changes since v1:
> - platform_get_irq now works for sparc, so that is used for all platforms
> - Acked by Peter Korsgaard <jacmet@sunsite.dk>
>
> drivers/i2c/busses/i2c-ocores.c | 9 +++++----
> 1 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c
> index bffd550..0b71dc6 100644
> --- a/drivers/i2c/busses/i2c-ocores.c
> +++ b/drivers/i2c/busses/i2c-ocores.c
> @@ -267,7 +267,8 @@ static int __devinit ocores_i2c_probe(struct platform_device *pdev)
> {
> struct ocores_i2c *i2c;
> struct ocores_i2c_platform_data *pdata;
> - struct resource *res, *res2;
> + struct resource *res;
> + int irq;
> int ret;
> int i;
>
> @@ -275,8 +276,8 @@ static int __devinit ocores_i2c_probe(struct platform_device *pdev)
> if (!res)
> return -ENODEV;
>
> - res2 = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> - if (!res2)
> + irq = platform_get_irq(pdev, 0);
> + if (irq < 0)
> return -ENODEV;
Why not pass the error code you got?
>
> i2c = devm_kzalloc(&pdev->dev, sizeof(*i2c), GFP_KERNEL);
> @@ -313,7 +314,7 @@ static int __devinit ocores_i2c_probe(struct platform_device *pdev)
> ocores_init(i2c);
>
> init_waitqueue_head(&i2c->wait);
> - ret = devm_request_irq(&pdev->dev, res2->start, ocores_isr, 0,
> + ret = devm_request_irq(&pdev->dev, irq, ocores_isr, 0,
> pdev->name, i2c);
> if (ret) {
> dev_err(&pdev->dev, "Cannot claim IRQ\n");
Rest looks good.
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-11-13 11:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 16:59 [PATCH v2 0/2] i2c: i2c-ocores: Add support for sparc, custom set and get functions, and the GRLIB port of the controller Andreas Larsson
2012-11-12 16:59 ` [PATCH v2 1/2] i2c: i2c-ocores: Add irq support for sparc Andreas Larsson
2012-11-13 11:10 ` Wolfram Sang [this message]
2012-11-13 13:18 ` Rob Herring
2012-11-13 16:31 ` Wolfram Sang
2012-11-12 16:59 ` [PATCH v2 2/2] i2c: i2c-ocores: Add support for the GRLIB port of the controller and custom getreg and setreg functions Andreas Larsson
2012-11-13 11:13 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121113111055.GF23119@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=andreas@gaisler.com \
--cc=ben-linux@fluff.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=jacmet@sunsite.dk \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=software@gaisler.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).