linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	ellyjones@chromium.org, Kay Sievers <kay@vrfy.org>,
	Roland Eggner <edvx1@systemanalysen.net>
Subject: Re: [PATCH v3] devtmpfs: mount with noexec and nosuid
Date: Wed, 21 Nov 2012 00:05:10 +0000	[thread overview]
Message-ID: <20121121000510.7a3c6673@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <20121120215059.GA1859@www.outflux.net>

> +config DEVTMPFS_SAFE
> +	bool "Use nosuid,noexec mount options on devtmpfs"
> +	depends on DEVTMPFS
> +	help
> +	  This instructs the kernel to include the MS_NOEXEC and
> +	  MS_NOSUID mount flags when mounting devtmpfs. This prevents
> +	  certain kinds of code-execution attacks on embedded platforms.

This description appears to be wrong as well as the code being pointless.
It doesn't prevent any meaningful code execution attacks and the config
entry might give people the delusion its useful or a security feature.

Please provide a valid and meaningful example.

  reply	other threads:[~2012-11-20 23:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-20 21:50 [PATCH v3] devtmpfs: mount with noexec and nosuid Kees Cook
2012-11-21  0:05 ` Alan Cox [this message]
2012-11-21  0:17   ` Kees Cook
2012-11-21  0:29     ` Alan Cox
2012-11-21  6:44 ` Roland Eggner
2012-11-21 12:42   ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121121000510.7a3c6673@pyramind.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=edvx1@systemanalysen.net \
    --cc=ellyjones@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kay@vrfy.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).