From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754010Ab2KUCBt (ORCPT ); Tue, 20 Nov 2012 21:01:49 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:42355 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752854Ab2KUCBr (ORCPT ); Tue, 20 Nov 2012 21:01:47 -0500 Subject: [PATCH 4/4] ext3: Warn if mounting rw on a disk requiring stable page writes To: axboe@kernel.dk, lucho@ionkov.net, jack@suse.cz, ericvh@gmail.com, tytso@mit.edu, rminnich@sandia.gov, viro@zeniv.linux.org.uk From: "Darrick J. Wong" Cc: martin.petersen@oracle.com, neilb@suse.de, david@fromorbit.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, adilger.kernel@dilger.ca, bharrosh@panasas.com, jlayton@samba.org, v9fs-developer@lists.sourceforge.net, linux-ext4@vger.kernel.org Date: Tue, 20 Nov 2012 18:00:56 -0800 Message-ID: <20121121020056.10225.15220.stgit@blackbox.djwong.org> In-Reply-To: <20121121020027.10225.43206.stgit@blackbox.djwong.org> References: <20121121020027.10225.43206.stgit@blackbox.djwong.org> User-Agent: StGit/0.15 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ext3 doesn't properly isolate pages from changes during writeback. Since the recommended fix is to use ext4, for now we'll just print a warning if the user tries to mount in write mode. Signed-off-by: Darrick J. Wong --- fs/ext3/super.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/fs/ext3/super.c b/fs/ext3/super.c index 5366393..5b3725d 100644 --- a/fs/ext3/super.c +++ b/fs/ext3/super.c @@ -1325,6 +1325,14 @@ static int ext3_setup_super(struct super_block *sb, struct ext3_super_block *es, "forcing read-only mode"); res = MS_RDONLY; } + if (!read_only && + queue_requires_stable_pages(bdev_get_queue(sb->s_bdev))) { + ext3_msg(sb, KERN_ERR, + "error: ext3 cannot safely write data to a disk " + "requiring stable pages writes; forcing read-only " + "mode. Upgrading to ext4 is recommended."); + res = MS_RDONLY; + } if (read_only) return res; if (!(sbi->s_mount_state & EXT3_VALID_FS))