From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: axboe@kernel.dk, lucho@ionkov.net, jack@suse.cz,
ericvh@gmail.com, tytso@mit.edu, rminnich@sandia.gov,
viro@zeniv.linux.org.uk, martin.petersen@oracle.com,
neilb@suse.de, david@fromorbit.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, adilger.kernel@dilger.ca,
bharrosh@panasas.com, jlayton@samba.org,
v9fs-developer@lists.sourceforge.net, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/4] mm: Only enforce stable page writes if the backing device requires it
Date: Wed, 21 Nov 2012 05:57:32 -0500 [thread overview]
Message-ID: <20121121105732.GB19050@infradead.org> (raw)
In-Reply-To: <20121121020041.10225.35875.stgit@blackbox.djwong.org>
On Tue, Nov 20, 2012 at 06:00:41PM -0800, Darrick J. Wong wrote:
> Create a helper function to check if a backing device requires stable page
> writes and, if so, performs the necessary wait. Then, make it so that all
> points in the memory manager that handle making pages writable use the helper
> function. This should provide stable page write support to most filesystems,
> while eliminating unnecessary waiting for devices that don't require the
> feature.
> +void wait_if_stable_page_write(struct page *page)
wait_for_stable_page() ?
Also this really needs a kerneldoc comment describing the usage.
next prev parent reply other threads:[~2012-11-21 10:57 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 2:00 [PATCH v2.1 0/3] mm/fs: Implement faster stable page writes on filesystems Darrick J. Wong
2012-11-21 2:00 ` [PATCH 1/4] bdi: Track users that require stable page writes Darrick J. Wong
2012-11-21 7:54 ` Christoph Hellwig
2012-11-21 10:52 ` Christoph Hellwig
2012-11-21 10:56 ` Christoph Hellwig
2012-11-21 21:52 ` Darrick J. Wong
2012-11-21 22:06 ` NeilBrown
2012-11-22 2:33 ` [PATCH] " Darrick J. Wong
2012-11-22 7:08 ` Christoph Hellwig
2012-11-21 2:00 ` [PATCH 2/4] mm: Only enforce stable page writes if the backing device requires it Darrick J. Wong
2012-11-21 10:57 ` Christoph Hellwig [this message]
2012-11-21 2:00 ` [PATCH 3/4] 9pfs: Fix filesystem to wait for stable page writeback Darrick J. Wong
2012-11-21 2:00 ` [PATCH 4/4] ext3: Warn if mounting rw on a disk requiring stable page writes Darrick J. Wong
2012-11-21 2:15 ` Jan Kara
2012-11-21 21:13 ` Darrick J. Wong
2012-11-21 21:33 ` Jan Kara
2012-11-21 21:47 ` NeilBrown
2012-11-22 1:47 ` Darrick J. Wong
2012-11-22 2:36 ` [RFC PATCH 1/2] mm: Introduce page flag to indicate stable page status Darrick J. Wong
2012-11-22 2:36 ` [RFC PATCH 2/2] jbd: Stabilize pages during writes when in ordered mode Darrick J. Wong
2012-11-22 9:19 ` Jan Kara
2012-11-22 9:12 ` [PATCH 4/4] ext3: Warn if mounting rw on a disk requiring stable page writes Jan Kara
2012-11-27 2:17 ` Darrick J. Wong
2012-12-05 12:12 ` Jan Kara
2012-12-08 1:09 ` Darrick J. Wong
2012-12-10 10:41 ` Jan Kara
2012-11-22 23:15 ` Dave Chinner
2012-12-13 8:07 [PATCH v2.3 0/3] mm/fs: Implement faster stable page writes on filesystems Darrick J. Wong
2012-12-13 8:07 ` [PATCH 2/4] mm: Only enforce stable page writes if the backing device requires it Darrick J. Wong
2012-12-17 9:16 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121121105732.GB19050@infradead.org \
--to=hch@infradead.org \
--cc=adilger.kernel@dilger.ca \
--cc=axboe@kernel.dk \
--cc=bharrosh@panasas.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=ericvh@gmail.com \
--cc=jack@suse.cz \
--cc=jlayton@samba.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=martin.petersen@oracle.com \
--cc=neilb@suse.de \
--cc=rminnich@sandia.gov \
--cc=tytso@mit.edu \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).