From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932597Ab2KVVn3 (ORCPT ); Thu, 22 Nov 2012 16:43:29 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:62775 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932185Ab2KVVnY (ORCPT ); Thu, 22 Nov 2012 16:43:24 -0500 Date: Wed, 21 Nov 2012 15:14:54 -0800 From: Greg KH To: Rupesh Gujare Cc: devel@driverdev.osuosl.org, sachin.kamat@linaro.org, linux-kernel@vger.kernel.org, Dan Carpenter Subject: Re: [V2 PATCH 1/3] staging: ozwpan: Remove redundant null check before kfree in ozpd.c Message-ID: <20121121231454.GA12536@kroah.com> References: <20121120163513.GC4990@kroah.com> <1353501977-6585-2-git-send-email-rgujare@ozmodevices.com> <20121121130527.GH11248@mwanda> <50ACDA54.7040508@ozmodevices.com> <20121121161859.GI6186@mwanda> <50AD0EB4.5070307@ozmodevices.com> <20121121214823.GA28532@kroah.com> <50AD5F54.4070609@ozmodevices.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50AD5F54.4070609@ozmodevices.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 21, 2012 at 11:10:12PM +0000, Rupesh Gujare wrote: > On 21/11/12 21:48, Greg KH wrote: > >On Wed, Nov 21, 2012 at 05:26:12PM +0000, Rupesh Gujare wrote: > >>On 21/11/12 16:19, Dan Carpenter wrote: > >>>When someone sends a patch there are a several possible responses: > >>>1) Ack the patch. > >>>2) Request that the submitter redo it. The downside is that no one > >>> likes redoing patches. > >>>3) Reject the patch. > >>>4) Redo it yourself and say "Based on a patch from Sachin Kamat". > >>> This isn't nice because everyone wants author credit. > >>>5) Redo it and get permission from the original author to give them > >>> author credit get their signed-off-by. > >>> > >>> > >>Thanks Dan > >> > >>I will keep it in mind in future. > >> > >>Sachin, > >> > >>Are you interested in redoing (or sending sign-off ?) for this patch > >>series ? I am more than happy to accept either. > >Don't worry, I'll clean up the mess here... > > > > > Sorry Greg, > > But looks like you applied V1 of this patch series, rather than V2. > Is that intentional ? Yes. You got the authorship version wrong on your set of patches, so I took V1 which correctly handled it. And, I commented on your one different patch. Please resend anything, based on the patches I took, if you want to see them done differently. thanks, greg k-h