From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030268Ab2KVUA6 (ORCPT ); Thu, 22 Nov 2012 15:00:58 -0500 Received: from mail-pb0-f46.google.com ([209.85.160.46]:59089 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030240Ab2KVTvj (ORCPT ); Thu, 22 Nov 2012 14:51:39 -0500 Date: Wed, 21 Nov 2012 16:38:35 -0800 From: Greg KH To: Jiri Slaby Cc: Sachin Kamat , linux-kernel@vger.kernel.org, patches@linaro.org Subject: Re: [PATCH 1/1] tty: vt: Remove redundant null check before kfree. Message-ID: <20121122003835.GA24936@kroah.com> References: <1353475147-28308-1-git-send-email-sachin.kamat@linaro.org> <20121121144624.GA21766@kroah.com> <50AD5916.3030604@suse.cz> <20121121230057.GA29095@kroah.com> <50AD60EC.3090302@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50AD60EC.3090302@suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 22, 2012 at 12:17:00AM +0100, Jiri Slaby wrote: > On 11/22/2012 12:00 AM, Greg KH wrote: > > On Wed, Nov 21, 2012 at 11:43:34PM +0100, Jiri Slaby wrote: > >> On 11/21/2012 03:46 PM, Greg KH wrote: > >>> On Wed, Nov 21, 2012 at 10:49:07AM +0530, Sachin Kamat wrote: > >>>> --- a/drivers/tty/vt/consolemap.c > >>>> +++ b/drivers/tty/vt/consolemap.c > >>>> @@ -410,10 +410,8 @@ static void con_release_unimap(struct uni_pagedir *p) > >>>> kfree(p->inverse_translations[i]); > >>>> p->inverse_translations[i] = NULL; > >>>> } > >>>> - if (p->inverse_trans_unicode) { > >>>> - kfree(p->inverse_trans_unicode); > >>>> - p->inverse_trans_unicode = NULL; > >>>> - } > >>>> + kfree(p->inverse_trans_unicode); > >>>> + p->inverse_trans_unicode = NULL; > >>> > >>> kfree with NULL is a no-op, but the line after that just caused a kernel > >>> crash if it was NULL, so I can't accept this type of thing. > >> > >> Greg, I'm not sure -- what do you mean here? The change actually looks > >> fine to me... We do not dereference p->inverse_trans_unicode there. > > > > If we never dereference it, why is it being set to NULL? > > I'm not disputing the assignment. Let it there. But I do not see any > issues with the patch. What problem do you see exactly? {sigh} Nothing. I don't know what I was thinking, my apologies Sachin, there's nothing wrong with this patch. I blame my fried brain, after reviewing all of those __dev* removal patches :) Sachin, can you resend these patches so I can apply them? thanks, greg k-h