From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759116Ab2KWJji (ORCPT ); Fri, 23 Nov 2012 04:39:38 -0500 Received: from mail-bk0-f46.google.com ([209.85.214.46]:46491 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759060Ab2KWJjg (ORCPT ); Fri, 23 Nov 2012 04:39:36 -0500 Date: Fri, 23 Nov 2012 09:39:31 +0000 From: Lee Jones To: Viresh Kumar Cc: sameo@linux.intel.com, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, spear-devel@list.st.com, Vipul Kumar Samar Subject: Re: [PATCH V2 2/2] mfd: stmpe: Extend DT support in stmpe driver Message-ID: <20121123093931.GE17471@gmail.com> References: <20121122112451.GE4328@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 23 Nov 2012, Viresh Kumar wrote: > On 22 November 2012 16:54, Lee Jones wrote: > >> diff --git a/Documentation/devicetree/bindings/mfd/stmpe.txt b/Documentation/devicetree/bindings/mfd/stmpe.txt > >> +Optional properties: > >> +- irq-trigger: IRQ trigger to use for the interrupt to the host > >> +- irq-invert-polarity: bool, IRQ line is connected with reversed polarity > > > > Are these new? > > > > When adding new bindings, ask yourself: > > I was trying to get information of these two bindings from other sources, > but couldn't find. The only other place can be the interrupts field, right? Bingo. Continue along this thread. > Because interrupts field depends on the interrupt controller, which can > be a wide variety of controllers in our case, we can't use that. Also, > the cells of interrupts field will have something that is required to be > programmed in the interrupt controller and not in the user of IC. > > But here we are talking about programming stmpe and so these bindings > are very much required in stmpe only. Not true. Hint: `git grep triggered -- Documentation/devicetree/` -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog