From: Sakari Ailus <sakari.ailus@iki.fi>
To: Prabhakar Lad <prabhakar.csengg@gmail.com>
Cc: LMML <linux-media@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
DLOS <davinci-linux-open-source@linux.davincidsp.com>,
Manjunath Hadli <manjunath.hadli@ti.com>,
Prabhakar Lad <prabhakar.lad@ti.com>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
laurent.pinchart@ideasonboard.com, hverkuil@xs4all.nl
Subject: Re: [PATCH v2 00/12] Media Controller capture driver for DM365
Date: Fri, 23 Nov 2012 15:13:44 +0200 [thread overview]
Message-ID: <20121123131344.GA31879@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <1353077114-19296-1-git-send-email-prabhakar.lad@ti.com>
Hi Prabhakar and others,
(Just resending; Laurent's e-mail address corrected, cc Hans, too.)
On Fri, Nov 16, 2012 at 08:15:02PM +0530, Prabhakar Lad wrote:
> From: Manjunath Hadli <manjunath.hadli@ti.com>
>
> This patch set adds media controller based capture driver for
> DM365.
>
> This driver bases its design on Laurent Pinchart's Media Controller Design
> whose patches for Media Controller and subdev enhancements form the base.
> The driver also takes copious elements taken from Laurent Pinchart and
> others' OMAP ISP driver based on Media Controller. So thank you all the
> people who are responsible for the Media Controller and the OMAP ISP driver.
>
> Also, the core functionality of the driver comes from the arago vpfe capture
> driver of which the isif capture was based on V4L2, with other drivers like
> ipipe, ipipeif and Resizer.
>
> Changes for v2:
> 1: Migrated the driver for videobuf2 usage pointed Hans.
> 2: Changed the design as pointed by Laurent, Exposed one more subdevs
> ipipeif and split the resizer subdev into three subdevs.
> 3: Rearrganed the patch sequence and changed the commit messages.
> 4: Changed the file architecture as pointed by Laurent.
>
> Manjunath Hadli (12):
> davinci: vpfe: add v4l2 capture driver with media interface
> davinci: vpfe: add v4l2 video driver support
> davinci: vpfe: dm365: add IPIPEIF driver based on media framework
> davinci: vpfe: dm365: add ISIF driver based on media framework
> davinci: vpfe: dm365: add IPIPE support for media controller driver
> davinci: vpfe: dm365: add IPIPE hardware layer support
> davinci: vpfe: dm365: resizer driver based on media framework
> davinci: vpss: dm365: enable ISP registers
> davinci: vpss: dm365: set vpss clk ctrl
> davinci: vpss: dm365: add vpss helper functions to be used in the
> main driver for setting hardware parameters
> davinci: vpfe: dm365: add build infrastructure for capture driver
> davinci: vpfe: Add documentation
As discussed, here's the todo list for inclusion to staging.
- User space interface refinement
- Controls should be used when possible rather than private ioctl
- No enums should be used
- Use of MC and V4L2 subdev APIs when applicable
- Single interface header might suffice
- Current interface forces to configure everything at once
- Get rid of the dm365_ipipe_hw.[ch] layer
- Active external sub-devices defined by link configuration; no strcmp
needed
- More generic platform data (i2c adapters)
- The driver should have no knowledge of possible external subdevs; see
struct vpfe_subdev_id
- Some of the hardware control should be refactorede
- Check proper serialisation (through mutexes and spinlocks)
- Names that are visible in kernel global namespace should have a common
prefix (or a few)
This list likely isn't complete, but some items such as the locking one is
there simply because I'm not certain of the state of it.
--
Kind regards,
Sakari Ailus
e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
next prev parent reply other threads:[~2012-11-23 13:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 14:45 [PATCH v2 00/12] Media Controller capture driver for DM365 Prabhakar Lad
2012-11-16 14:45 ` [PATCH v2 01/12] davinci: vpfe: add v4l2 capture driver with media interface Prabhakar Lad
2012-11-16 14:45 ` [PATCH v2 02/12] davinci: vpfe: add v4l2 video driver support Prabhakar Lad
2012-11-16 14:45 ` [PATCH v2 03/12] davinci: vpfe: dm365: add IPIPEIF driver based on media framework Prabhakar Lad
2012-11-16 14:45 ` [PATCH v2 04/12] davinci: vpfe: dm365: add ISIF " Prabhakar Lad
2012-11-16 14:45 ` [PATCH v2 05/12] davinci: vpfe: dm365: add IPIPE support for media controller driver Prabhakar Lad
2012-11-16 14:45 ` [PATCH v2 06/12] davinci: vpfe: dm365: add IPIPE hardware layer support Prabhakar Lad
2012-11-16 14:45 ` [PATCH v2 07/12] davinci: vpfe: dm365: resizer driver based on media framework Prabhakar Lad
2012-11-16 14:45 ` [PATCH v2 08/12] davinci: vpss: dm365: enable ISP registers Prabhakar Lad
2012-11-16 14:45 ` [PATCH v2 09/12] davinci: vpss: dm365: set vpss clk ctrl Prabhakar Lad
2012-11-16 14:45 ` [PATCH v2 10/12] davinci: vpss: dm365: add vpss helper functions to be used in the main driver for setting hardware parameters Prabhakar Lad
2012-11-16 14:45 ` [PATCH v2 11/12] davinci: vpfe: dm365: add build infrastructure for capture driver Prabhakar Lad
2012-11-16 14:45 ` [PATCH v2 12/12] davinci: vpfe: Add documentation Prabhakar Lad
2012-11-16 14:53 ` [PATCH v2 00/12] Media Controller capture driver for DM365 Prabhakar Lad
2012-11-21 20:56 ` Sakari Ailus
2012-11-22 23:53 ` Sakari Ailus
2012-11-23 13:13 ` Sakari Ailus [this message]
2012-11-23 13:21 ` Prabhakar Lad
2012-11-23 13:57 ` Sakari Ailus
2012-11-23 14:01 ` Hans Verkuil
2012-11-25 16:27 ` Prabhakar Lad
2012-11-26 0:28 ` Sakari Ailus
2012-11-26 3:55 ` Prabhakar Lad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121123131344.GA31879@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=manjunath.hadli@ti.com \
--cc=mchehab@infradead.org \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.lad@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).