From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Qing Xu <qingx@marvell.com>
Cc: "lrg@ti.com" <lrg@ti.com>,
"haojian.zhuang@gmail.com" <haojian.zhuang@gmail.com>,
Chao Xie <cxie4@marvell.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: max8925: fix compiler warnings
Date: Sat, 24 Nov 2012 18:55:55 +0100 [thread overview]
Message-ID: <20121124175554.GF4719@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <50AEDF00.7060709@marvell.com>
[-- Attachment #1: Type: text/plain, Size: 940 bytes --]
On Fri, Nov 23, 2012 at 10:27:12AM +0800, Qing Xu wrote:
> But, in fact, it is not necessary to initialize regulator_idx.
> for (i = 0; i < ARRAY_SIZE(max8925_regulator_info); i++) {
> ri = &max8925_regulator_info[i];
> if (ri->vol_reg == res->start) {
> ****** if regulator_idx can not get a match "i" here, it will return
> -EINVAL in below code
> regulator_idx = i;
> break;
> }
> }
> if (i == ARRAY_SIZE(max8925_regulator_info)) {
> dev_err(&pdev->dev, "Failed to find regulator %llu\n",
> (unsigned long long)res->start);
> return -EINVAL;
> }
> How to solve such compiler warning?
Typically by reporting a compiler bug, though sometimes in the process
of doing that one finds out that there's some non-obvious way in which
the code can break.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-11-24 17:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 2:11 [PATCH] regulator: max8925: fix compiler warnings Qing Xu
2012-11-23 1:41 ` Mark Brown
2012-11-23 2:27 ` Qing Xu
2012-11-24 17:55 ` Mark Brown [this message]
2012-11-26 3:07 ` Qing Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121124175554.GF4719@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=cxie4@marvell.com \
--cc=haojian.zhuang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=qingx@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).