From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753451Ab2KYVD6 (ORCPT ); Sun, 25 Nov 2012 16:03:58 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:40701 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753390Ab2KYVD5 (ORCPT ); Sun, 25 Nov 2012 16:03:57 -0500 Date: Sun, 25 Nov 2012 16:03:53 -0500 (EST) Message-Id: <20121125.160353.581132618272394748.davem@davemloft.net> To: mkubecek@suse.cz Cc: netdev@vger.kernel.org, fubar@us.ibm.com, andy@greyhouse.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bonding: in balance-rr mode, set curr_active_slave only if it is up From: David Miller In-Reply-To: <20121122125202.14252C35B8@unicorn.suse.cz> References: <20121122125202.14252C35B8@unicorn.suse.cz> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michal Kubecek Date: Thu, 22 Nov 2012 13:48:39 +0100 > If all slaves of a balance-rr bond with ARP monitor are enslaved > with down link state, bond keeps down state even after slaves > go up. > > This is caused by bond_enslave() setting curr_active_slave to > first slave not taking into account its link state. As > bond_loadbalance_arp_mon() uses curr_active_slave to identify > whether slave's down->up transition should update bond's link > state, bond stays down even if slaves are up (until first slave > goes from up to down at least once). > > Before commit f31c7937 "bonding: start slaves with link down for > ARP monitor", this was masked by slaves always starting in UP > state with ARP monitor (and MII monitor not relying on > curr_active_slave being NULL if there is no slave up). > > Signed-off-by: Michal Kubecek Jay/Andy please review.