From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755941Ab2KZSVA (ORCPT ); Mon, 26 Nov 2012 13:21:00 -0500 Received: from quartz.orcorp.ca ([184.70.90.242]:34372 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755823Ab2KZSU6 (ORCPT ); Mon, 26 Nov 2012 13:20:58 -0500 Date: Mon, 26 Nov 2012 11:20:54 -0700 From: Jason Gunthorpe To: Grant Likely Cc: linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, Rob Herring Subject: Re: [PATCH] of: When constructing the bus id consider assigned-addresses as well Message-ID: <20121126182054.GA30177@obsidianresearch.com> References: <20121121210240.GC15285@obsidianresearch.com> <20121126140316.99FE23E194B@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121126140316.99FE23E194B@localhost> User-Agent: Mutt/1.5.21 (2010-09-15) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.162 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 26, 2012 at 02:03:16PM +0000, Grant Likely wrote: > On Wed, 21 Nov 2012 14:02:40 -0700, Jason Gunthorpe wrote: > > 'assigned-addresses' is used for certain PCI device type nodes in > > lieu of 'reg', since this is enforced by of/address.c, have > > of_device_make_bus_id look there as well. > > > > Signed-off-by: Jason Gunthorpe > > If it is a PCI device, then of_device_make_bus_id() shouldn't come into > play. PCI devices already have their own naming scheme. Only > platform_bus device creation uses of_device_make_bus_id(). What am I > missing? In my embedded case I have a complex PCI-E connected SOC device. This is modeled in OF by having a PCI-E bus, a PCI-E device node, and then all of the SOC devices (I2C, GPIO, drivers, etc) placed under the PCI-E device node. The PCI driver that matches the device just turns it on and calls of_platform_populate(..) with its own node as an argument. So of_device_make_bus_id isn't called on a PCI-E device node, it is called on the platform_device children of that node, and due to the way the other code works, and what the OF rules seem to be, those childen all use assigned-addresses. Without this patch the code just assigns monotonic ids to those nodes. Jason