linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@elte.hu>, Paul Mackerras <paulus@samba.org>,
	Corey Ashford <cjashfor@linux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH 09/14] perf diff: Update perf diff documentation for multiple data comparison
Date: Thu, 29 Nov 2012 13:06:12 +0100	[thread overview]
Message-ID: <20121129120612.GC1096@krava.brq.redhat.com> (raw)
In-Reply-To: <87ip8oocct.fsf@sejong.aot.lge.com>

On Thu, Nov 29, 2012 at 08:52:18PM +0900, Namhyung Kim wrote:
> On Wed, 28 Nov 2012 14:52:44 +0100, Jiri Olsa wrote:
> > +COMPARISON
> > +----------
> > +The comparison is governed by the baseline file. The baseline perf.data
> > +file is iterated for samples. All other perf.data files specified on
> > +the command line are searched for the baseline sample pair. If the pair
> > +is found, specified computation is made and result is displayed.
> > +
> > +All samples from non-baseline perf.data files, that do not match any
> > +baseline entry, are displayed with empty space within baseline column
> > +and possible computation results (delta) in their related column.
> > +
> > +Example files samples:
> > +- file A with samples f1, f2, f3, f4,    f6
> > +- file B with samples     f2,     f4, f5
> > +- file C with samples f1, f2,         f5
> > +
> > +Example output:
> > +  x - computation takes place for pair
> > +  b - baseline sample percentage
> > +
> > +- perf diff A B C
> > +
> > +  baseline/A compute/B compute/C  samples
> > +  ---------------------------------------
> > +  b                    x          f1
> > +  b          x         x          f2
> > +  b                               f3
> > +  b          x                    f4
> > +  b                               f6
> > +             x         x          f5
> > +
> > +- perf diff B A C
> > +
> > +  baseline/B compute/A compute/C  samples
> > +  ---------------------------------------
> > +  b          x         x          f2
> > +  b          x                    f4
> > +  b                    x          f5
> > +             x         x          f1
> > +             x                    f3
> > +             x                    f6
> > +
> > +- perf diff C B A
> > +
> > +  baseline/C compute/B compute/A  samples
> > +  ---------------------------------------
> > +  b                    x          f1
> > +  b          x         x          f2
> > +  b          x                    f5
> > +                       x          f3
> > +             x         x          f4
> > +                       x          f6
> > +
> 
> It seems not work this way.  When I test multiple diff, I didn't get
> consecutive 'b's on the baseline column like your example in the cover
> letter of this series.

the baseline consecutiveness is just for sake of the doc readibility
it just presents logical output to get user some idea 

final output could be sorted by column data using -o <column number>

the initial diff output (no options) is sort of sorted by baseline ;)
you're right, that should be fixed.. by default sorted by baseline

jirka

  reply	other threads:[~2012-11-29 12:06 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-28 13:52 [PATCH/RFC 00/14] perf, tool: Fix endian issues Jiri Olsa
2012-11-28 13:52 ` [PATCH 01/14] perf tool: Introduce perf_hpp__list for period related columns Jiri Olsa
2012-11-29  7:44   ` Namhyung Kim
2012-11-29 10:52     ` Namhyung Kim
2012-11-28 13:52 ` [PATCH 02/14] perf tool: Add struct perf_hpp_fmt into hpp callbacks Jiri Olsa
2012-11-28 13:52 ` [PATCH 03/14] perf tool: Fix period symbol_conf.field_sep display Jiri Olsa
2012-11-29  7:56   ` Namhyung Kim
2012-11-29 11:53     ` Jiri Olsa
2012-11-29 13:40       ` [PATCH] perf hists: Fix period symbol_conf.field_sep display, again Jiri Olsa
2012-11-29 17:35         ` Arnaldo Carvalho de Melo
2012-11-28 13:52 ` [PATCH 04/14] perf diff: Remove displacement from struct hist_entry_diff Jiri Olsa
2012-11-29  8:00   ` Namhyung Kim
2013-01-24 18:50   ` [tip:perf/core] " tip-bot for Jiri Olsa
2012-11-28 13:52 ` [PATCH 05/14] perf diff: Change compute methods to work with pair directly Jiri Olsa
2012-11-29 11:15   ` Namhyung Kim
2013-01-24 18:51   ` [tip:perf/core] " tip-bot for Jiri Olsa
2012-11-28 13:52 ` [PATCH 06/14] perf diff: Change formula " Jiri Olsa
2012-11-29 11:15   ` Namhyung Kim
2013-01-24 18:52   ` [tip:perf/core] " tip-bot for Jiri Olsa
2012-11-28 13:52 ` [PATCH 07/14] perf diff: Add callback to hists__match/hists__link functions Jiri Olsa
2012-11-28 13:52 ` [PATCH 08/14] perf diff: Change diff command to work over multiple data files Jiri Olsa
2012-11-29 11:37   ` Namhyung Kim
2012-11-29 11:53     ` Jiri Olsa
2012-11-28 13:52 ` [PATCH 09/14] perf diff: Update perf diff documentation for multiple data comparison Jiri Olsa
2012-11-29 11:52   ` Namhyung Kim
2012-11-29 12:06     ` Jiri Olsa [this message]
2012-11-28 13:52 ` [PATCH 10/14] perf tool: Centralize default columns init in perf_hpp__init Jiri Olsa
2012-11-29 11:55   ` Namhyung Kim
2012-11-29 12:13     ` Jiri Olsa
2012-11-30  5:06       ` Namhyung Kim
2012-11-30 11:56         ` Jiri Olsa
2012-11-28 13:52 ` [PATCH 11/14] perf diff: Making compute functions static Jiri Olsa
2012-11-28 13:52 ` [PATCH 12/14] perf diff: Display data file info ahead of the diff output Jiri Olsa
2012-11-28 13:52 ` [PATCH 13/14] perf diff: Display zero calculation results Jiri Olsa
2012-11-28 13:52 ` [PATCH 14/14] perf diff: Add generic order option for compute sorting Jiri Olsa
2012-11-29 12:02   ` Namhyung Kim
2012-11-29 12:19     ` Jiri Olsa
2012-11-28 13:56 ` [PATCH/RFC 00/14] perf, diff: Support for multiple files Jiri Olsa
2012-11-28 15:57   ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121129120612.GC1096@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=cjashfor@linux.vnet.ibm.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=namhyung@kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).