From: Anton Vorontsov <cbouatmailru@gmail.com>
To: "Tc, Jenny" <jenny.tc@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
"myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
anish kumar <anish198519851985@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
"Pallala, Ramakrishna" <ramakrishna.pallala@intel.com>
Subject: Re: [PATCH] EXTCON: Get and set cable properties
Date: Sun, 2 Dec 2012 17:29:16 -0800 [thread overview]
Message-ID: <20121203012916.GA7330@lizard.sbx05977.paloaca.wayport.net> (raw)
In-Reply-To: <20ADAB092842284E95860F279283C564E2754F@BGSMSX101.gar.corp.intel.com>
On Sun, Dec 02, 2012 at 06:53:17AM +0000, Tc, Jenny wrote:
> Could you please review this. This is a follow up patch for "PATCH]
> extcon : callback function to read cable property"
While I see nothing wrong with the patch itself, I beg you to send some
users for the new calls. Don't be obsessed with the extcon internals too
much, think more about how things will interact (i.e. I really really want
to see how you use these calls from the power supply drivers).
Thanks,
Anton.
next prev parent reply other threads:[~2012-12-03 1:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 21:49 [PATCH] EXTCON: Get and set cable properties Jenny TC
2012-12-02 6:53 ` Tc, Jenny
2012-12-03 1:29 ` Anton Vorontsov [this message]
2012-12-03 2:09 ` Tc, Jenny
2012-12-15 2:55 ` Tc, Jenny
2013-01-06 2:19 ` Anton Vorontsov
2012-12-03 1:13 ` Chanwoo Choi
2012-12-03 1:53 ` Tc, Jenny
2012-12-03 5:29 ` anish kumar
2012-12-15 0:16 ` Tc, Jenny
2012-12-17 0:38 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121203012916.GA7330@lizard.sbx05977.paloaca.wayport.net \
--to=cbouatmailru@gmail.com \
--cc=anish198519851985@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cw00.choi@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jenny.tc@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=ramakrishna.pallala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).