From: "Suzuki K. Poulose" <suzuki@in.ibm.com>
To: bigeasy@linutronix.de, oleg@redhat.com, ananth@in.ibm.com,
srikar@linux.vnet.ibm.com
Cc: peterz@infradead.org, benh@kernel.crashing.org, mingo@elte.hu,
anton@redhat.com, linux-kernel@vger.kernel.org
Subject: [PATCH v2 4/4] uprobes/powerpc: Make use of generic routines to enable single step
Date: Mon, 03 Dec 2012 20:40:32 +0530 [thread overview]
Message-ID: <20121203150946.7727.82735.stgit@suzukikp> (raw)
In-Reply-To: <20121203150438.7727.74924.stgit@suzukikp>
From: Suzuki K. Poulose <suzuki@in.ibm.com>
Replace the ptrace helpers with the powerpc generic routines to
enable/disable single step. We save/restore the MSR (and DCBR for BookE)
across for the operation. We don't have to disable the single step,
as restoring the MSR/DBCR would restore the previous state.
Signed-off-by: Suzuki K. Poulose <suzuki@in.ibm.com>
---
arch/powerpc/include/asm/uprobes.h | 4 ++++
arch/powerpc/kernel/uprobes.c | 26 +++++++++++++++++---------
2 files changed, 21 insertions(+), 9 deletions(-)
diff --git a/arch/powerpc/include/asm/uprobes.h b/arch/powerpc/include/asm/uprobes.h
index b532060..10a521c 100644
--- a/arch/powerpc/include/asm/uprobes.h
+++ b/arch/powerpc/include/asm/uprobes.h
@@ -43,6 +43,10 @@ struct arch_uprobe {
struct arch_uprobe_task {
unsigned long saved_trap_nr;
+ unsigned long saved_msr;
+#ifdef CONFIG_PPC_ADV_DEBUG_REGS
+ unsigned long saved_dbcr0;
+#endif
};
extern int arch_uprobe_analyze_insn(struct arch_uprobe *aup, struct mm_struct *mm, unsigned long addr);
diff --git a/arch/powerpc/kernel/uprobes.c b/arch/powerpc/kernel/uprobes.c
index 1a62353..6af55c4 100644
--- a/arch/powerpc/kernel/uprobes.c
+++ b/arch/powerpc/kernel/uprobes.c
@@ -52,14 +52,25 @@ int arch_uprobe_analyze_insn(struct arch_uprobe *auprobe,
return 0;
}
-static void uprobe_save_context_sstep(struct arch_uprobe_task *autask)
+static void uprobe_save_context_sstep(struct arch_uprobe_task *autask,
+ struct pt_regs *regs)
{
autask->saved_trap_nr = current->thread.trap_nr;
+ autask->saved_msr = regs->msr;
+#ifdef CONFIG_PPC_ADV_DEBUG_REGS
+ autask->saved_dbcr0 = mfspr(SPRN_DBCR0);
+#endif
}
-static void uprobe_restore_context_sstep(struct arch_uprobe_task *autask)
+static void uprobe_restore_context_sstep(struct arch_uprobe_task *autask,
+ struct pt_regs *regs)
{
current->thread.trap_nr = autask->saved_trap_nr;
+
+ regs->msr = autask->saved_msr;
+#ifdef CONFIG_PPC_ADV_DEBUG_REGS
+ mtspr(SPRN_DBCR0, autask->saved_dbcr0);
+#endif
}
/*
@@ -71,11 +82,11 @@ int arch_uprobe_pre_xol(struct arch_uprobe *auprobe, struct pt_regs *regs)
{
struct arch_uprobe_task *autask = ¤t->utask->autask;
- uprobe_save_context_sstep(autask);
+ uprobe_save_context_sstep(autask, regs);
current->thread.trap_nr = UPROBE_TRAP_NR;
regs->nip = current->utask->xol_vaddr;
- user_enable_single_step(current);
+ enable_single_step(regs);
return 0;
}
@@ -121,7 +132,7 @@ int arch_uprobe_post_xol(struct arch_uprobe *auprobe, struct pt_regs *regs)
WARN_ON_ONCE(current->thread.trap_nr != UPROBE_TRAP_NR);
- uprobe_restore_context_sstep(&utask->autask);
+ uprobe_restore_context_sstep(&utask->autask, regs);
/*
* On powerpc, except for loads and stores, most instructions
@@ -132,7 +143,6 @@ int arch_uprobe_post_xol(struct arch_uprobe *auprobe, struct pt_regs *regs)
*/
regs->nip = utask->vaddr + MAX_UINSN_BYTES;
- user_disable_single_step(current);
return 0;
}
@@ -174,10 +184,8 @@ void arch_uprobe_abort_xol(struct arch_uprobe *auprobe, struct pt_regs *regs)
{
struct uprobe_task *utask = current->utask;
- uprobe_restore_context_sstep(&utask->autask);
+ uprobe_restore_context_sstep(&utask->autask, regs);
instruction_pointer_set(regs, utask->vaddr);
-
- user_disable_single_step(current);
}
/*
next prev parent reply other threads:[~2012-12-03 15:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 15:07 [PATCH v2 0/4] uprobes/powerpc: Replace ptrace helpers for single stepping Suzuki K. Poulose
2012-12-03 15:07 ` [PATCH v2 1/4] kprobes/powerpc: Do not disable External interrupts during single step Suzuki K. Poulose
2012-12-11 5:48 ` Suzuki K. Poulose
2013-01-04 4:42 ` Benjamin Herrenschmidt
2013-01-07 12:03 ` Sebastian Andrzej Siewior
2012-12-03 15:08 ` [PATCH v2 2/4] powerpc: Move the single step enable code to a generic path Suzuki K. Poulose
2012-12-10 10:34 ` Ananth N Mavinakayanahalli
2012-12-03 15:09 ` [PATCH v2 3/4] uprobes/powerpc: Introduce routines for save/restore context Suzuki K. Poulose
2012-12-03 15:15 ` Ananth N Mavinakayanahalli
2012-12-03 15:48 ` Suzuki K. Poulose
2012-12-10 10:35 ` Ananth N Mavinakayanahalli
2012-12-03 15:10 ` Suzuki K. Poulose [this message]
2012-12-10 10:35 ` [PATCH v2 4/4] uprobes/powerpc: Make use of generic routines to enable single step Ananth N Mavinakayanahalli
2012-12-14 20:02 ` Oleg Nesterov
2012-12-18 5:11 ` Suzuki K. Poulose
2012-12-18 5:36 ` Ananth N Mavinakayanahalli
2012-12-18 19:10 ` Oleg Nesterov
2012-12-19 4:53 ` Ananth N Mavinakayanahalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121203150946.7727.82735.stgit@suzukikp \
--to=suzuki@in.ibm.com \
--cc=ananth@in.ibm.com \
--cc=anton@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).