From: Michal Hocko <mhocko@suse.cz>
To: Tejun Heo <tj@kernel.org>
Cc: lizefan@huawei.com, paul@paulmenage.org, glommer@parallels.com,
containers@lists.linux-foundation.org, cgroups@vger.kernel.org,
peterz@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] cpuset: implement cgroup_rightmost_descendant()
Date: Mon, 3 Dec 2012 17:03:10 +0100 [thread overview]
Message-ID: <20121203160310.GD17093@dhcp22.suse.cz> (raw)
In-Reply-To: <1354141621-11906-2-git-send-email-tj@kernel.org>
On Wed 28-11-12 14:26:59, Tejun Heo wrote:
> Implement cgroup_rightmost_descendant() which returns the right most
> descendant of the specified cgroup. This can be used to skip the
> cgroup's subtree while iterating with
> cgroup_for_each_descendant_pre().
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Michal Hocko <mhocko@suse.cz>
Acked-by: Michal Hocko <mhocko@suse.cz>
Just a nit bellow
[...]
> +/**
> + * cgroup_rightmost_descendant - return the rightmost descendant of a cgroup
> + * @cgrp: cgroup of interest
> + *
> + * Return the rightmost descendant of @cgrp. If there's no descendant,
> + * @cgrp is returned. This can be used during pre-order traversal to skip
> + * subtree of @cgrp.
> + */
s/cgrp/pos/
> +struct cgroup *cgroup_rightmost_descendant(struct cgroup *pos)
[...]
Thanks
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2012-12-03 16:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 22:26 [PATCHSET cgroup/for-3.8] cpuset: drop cpuset->stack_list and ->parent Tejun Heo
2012-11-28 22:26 ` [PATCH 1/3] cpuset: implement cgroup_rightmost_descendant() Tejun Heo
2012-12-03 16:03 ` Michal Hocko [this message]
2012-11-28 22:27 ` [PATCH 2/3] cpuset: replace cpuset->stack_list with cpuset_for_each_descendant_pre() Tejun Heo
2012-12-03 16:18 ` Michal Hocko
2012-11-28 22:27 ` [PATCH 3/3] cpuset: remove cpuset->parent Tejun Heo
2012-12-03 16:20 ` Michal Hocko
2012-12-03 15:55 ` [PATCHSET cgroup/for-3.8] cpuset: drop cpuset->stack_list and ->parent Michal Hocko
2013-01-03 21:44 [PATCHSET] cpuset: drop cpuset->stack_list and ->parent, take#2 Tejun Heo
2013-01-03 21:44 ` [PATCH 1/3] cpuset: implement cgroup_rightmost_descendant() Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121203160310.GD17093@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=glommer@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=paul@paulmenage.org \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).